[ 
https://issues.apache.org/jira/browse/HDDS-1810?focusedWorklogId=303442&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-303442
 ]

ASF GitHub Bot logged work on HDDS-1810:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 29/Aug/19 07:48
            Start Date: 29/Aug/19 07:48
    Worklog Time Spent: 10m 
      Work Description: elek commented on pull request #1224: HDDS-1810. SCM 
command to Activate and Deactivate pipelines.
URL: https://github.com/apache/hadoop/pull/1224#discussion_r318929542
 
 

 ##########
 File path: 
hadoop-hdds/common/src/main/java/org/apache/hadoop/ozone/protocolPB/StorageContainerLocationProtocolServerSideTranslatorPB.java
 ##########
 @@ -257,6 +265,32 @@ public ListPipelineResponseProto listPipelines(
     }
   }
 
+  @Override
+  public ActivatePipelineResponseProto activatePipeline(
+      RpcController controller, ActivatePipelineRequestProto request)
+      throws ServiceException {
+    try (Scope ignored = TracingUtil
+        .importAndCreateScope("activatePipeline", request.getTraceID())) {
+      impl.activatePipeline(request.getPipelineID());
+      return ActivatePipelineResponseProto.newBuilder().build();
+    } catch (IOException e) {
+      throw new ServiceException(e);
+    }
+  }
+
+  @Override
+  public DeactivatePipelineResponseProto deactivatePipeline(
+      RpcController controller, DeactivatePipelineRequestProto request)
+      throws ServiceException {
+    try (Scope ignored = TracingUtil
+        .importAndCreateScope("activatePipeline", request.getTraceID())) {
 
 Review comment:
   should be "deactivatePipeline"
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 303442)
    Time Spent: 2.5h  (was: 2h 20m)

> SCM command to Activate and Deactivate pipelines
> ------------------------------------------------
>
>                 Key: HDDS-1810
>                 URL: https://issues.apache.org/jira/browse/HDDS-1810
>             Project: Hadoop Distributed Data Store
>          Issue Type: New Feature
>          Components: SCM, SCM Client
>            Reporter: Nanda kumar
>            Assignee: Nanda kumar
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
>
> It will be useful to have scm command to temporarily deactivate and 
> re-activate a pipeline. This will help us a lot in debugging a pipeline.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to