[
https://issues.apache.org/jira/browse/HDDS-1879?focusedWorklogId=304438&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304438
]
ASF GitHub Bot logged work on HDDS-1879:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Aug/19 17:37
Start Date: 30/Aug/19 17:37
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1194: HDDS-1879.
Support multiple excluded scopes when choosing datanodes in NetworkTopology
URL: https://github.com/apache/hadoop/pull/1194#discussion_r319611648
##########
File path:
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/net/NetworkTopologyImpl.java
##########
@@ -556,17 +571,17 @@ private Node chooseNodeInternal(String scope, int
leafIndex,
int nodeIndex;
if (leafIndex >= 0) {
nodeIndex = leafIndex % availableNodes;
- ret = ((InnerNode)scopeNode).getLeaf(nodeIndex, excludedScope,
+ ret = ((InnerNode)scopeNode).getLeaf(nodeIndex, mutableExcludedScopes,
mutableExNodes, ancestorGen);
} else {
nodeIndex = ThreadLocalRandom.current().nextInt(availableNodes);
- ret = ((InnerNode)scopeNode).getLeaf(nodeIndex, excludedScope,
+ ret = ((InnerNode)scopeNode).getLeaf(nodeIndex, mutableExcludedScopes,
mutableExNodes, ancestorGen);
}
LOG.debug("Choosing node[index={},random={}] from \"{}\" available nodes" +
" scope=\"{}\", excludedScope=\"{}\", excludeNodes=\"{}\".",
Review comment:
same as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 304438)
Time Spent: 2h 10m (was: 2h)
> Support multiple excluded scopes when choosing datanodes in NetworkTopology
> ---------------------------------------------------------------------------
>
> Key: HDDS-1879
> URL: https://issues.apache.org/jira/browse/HDDS-1879
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Sammi Chen
> Assignee: Sammi Chen
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
