[ 
https://issues.apache.org/jira/browse/HDFS-14726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16919875#comment-16919875
 ] 

Jonathan Hung commented on HDFS-14726:
--------------------------------------

I've marked it as a 2.10 blocker.

[~vagarychen]/[~xkrogen] can we check the test failures? If they're not 
related, is this ready to be committed?

Another thing, upon reading the description it seems this was caused by 
HDFS-10519 which seems to be part of another commit: {noformat}commit 
85f81fe458eb170816e6251c3a859ffac3b0a480
Author: Erik Krogen <[email protected]>
Date:   Tue May 22 16:45:26 2018 -0700

    HDFS-13609. [SBN read] Edit Tail Fast Path Part 3: NameNode-side changes to 
support tailing edits via RPC. Contributed by Erik Krogen.
    HDFS-10519. Add a configuration option to enable in-progress edit log 
tailing. Contributed by Jiayi Zhou.{noformat}

Do we need to mark 2.10.0 as a fix-version on HDFS-10519? Furthermore do we 
plan to mark fix versions on the other [SBN read] commits?

> Fix JN incompatibility issue in branch-2 due to backport of HDFS-10519
> ----------------------------------------------------------------------
>
>                 Key: HDFS-14726
>                 URL: https://issues.apache.org/jira/browse/HDFS-14726
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: journal-node
>    Affects Versions: 2.10.0
>            Reporter: Chen Liang
>            Assignee: Chen Liang
>            Priority: Blocker
>              Labels: release-blocker
>         Attachments: HDFS-14726-branch-2.001.patch, 
> HDFS-14726-branch-2.002.patch, HDFS-14726-branch-2.003.patch
>
>
> HDFS-10519 has been backported to branch-2. However HDFS-10519 introduced an 
> incompatibility issue between NN and JN due to the new protobuf field 
> {{committedTxnId}} in {{HdfsServer.proto}}. This field was introduced as a 
> required field so if JN and NN are not on same version, it will run into 
> missing field exception. Although currently we can get around by making sure 
> JN always gets upgraded properly before NN, we can potentially fix this 
> incompatibility by changing the field to optional. 



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to