[
https://issues.apache.org/jira/browse/HDFS-11291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920118#comment-16920118
]
Surendra Singh Lilhore commented on HDFS-11291:
-----------------------------------------------
Thanks [~hemanthboyina] for patch.
{quote}One more change required is, in both cases, where there is no edit txn
added, no need to wait for logSync().
{quote}
[~vinayakumarb], logSync() can be avoid by checking the current call
transaction ID, which will be stored in {{FSEditLog.myTransactionId}}, if edit
logging is skipped then {{myTransactionId}} will be {{Long.MAX_VALUE}}. If the
value is {{Long.MAX_VALUE}} then no need to do the {{logSync()}}.
{quote}Also I have doubt whether its correct to log audit when there is no
change done and no edit txn added.
{quote}
I feel this should be done, because for user this operation is done and
whatever value he given it is available in namespace.
[~vinayakumarb], What is your opinion ?
> Avoid unnecessary edit log for setStoragePolicy() and setReplication()
> ----------------------------------------------------------------------
>
> Key: HDFS-11291
> URL: https://issues.apache.org/jira/browse/HDFS-11291
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Surendra Singh Lilhore
> Assignee: hemanthboyina
> Priority: Major
> Attachments: HDFS-11291.001.patch, HDFS-11291.002.patch,
> HDFS-11291.003.patch
>
>
> We are setting the storage policy for file without checking the current
> policy of file for avoiding extra getStoragePolicy() rpc call. Currently
> namenode is not checking the current storage policy before setting new one
> and adding edit logs. I think if the old and new storage policy is same we
> can avoid set operation.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
