[ 
https://issues.apache.org/jira/browse/HDFS-14654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920307#comment-16920307
 ] 

Ayush Saxena edited comment on HDFS-14654 at 9/1/19 7:38 AM:
-------------------------------------------------------------

Thaxn [~zhangchen] for the patch.
I guess in {{TestRouterRpc}} {{resolver.setDisableRegistration(true);}} this 
should be reverted back in the finally block, if there is an error before we 
set to false, it may affect the following tests.


was (Author: ayushtkn):
Thaxn [~zhangchen] for the patch.
v004 LGTM +1

> RBF: TestRouterRpc#testNamenodeMetrics is flaky
> -----------------------------------------------
>
>                 Key: HDFS-14654
>                 URL: https://issues.apache.org/jira/browse/HDFS-14654
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Takanobu Asanuma
>            Assignee: Chen Zhang
>            Priority: Major
>         Attachments: HDFS-14654.001.patch, HDFS-14654.002.patch, 
> HDFS-14654.003.patch, HDFS-14654.004.patch, error.log
>
>
> They sometimes pass and sometimes fail.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to