[
https://issues.apache.org/jira/browse/HDFS-14810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16920407#comment-16920407
]
Ayush Saxena commented on HDFS-14810:
-------------------------------------
Thanx [~hexiaoqiao]
I had a quick view of the patch. Looks good overall, Couple of doubts :
* In SetReplication() now we will be doing {{getEditLog().logSync()}} with even
success being false?
* Similarlly in {{clearCorruptLazyPersistFiles()}} and renameTo sync even
unchanged.
* Some places we are now logging success variable, instead true as in setRep().
There was a discussion in {{HDFS-13772}} Xiao Chen mentioned audit false should
be only for ACE, May be you can check once the discussion there.
SetErasureCodingPolicy doesn't log audit for ACE?
> review FSNameSystem editlog sync
> --------------------------------
>
> Key: HDFS-14810
> URL: https://issues.apache.org/jira/browse/HDFS-14810
> Project: Hadoop HDFS
> Issue Type: Improvement
> Components: namenode
> Reporter: He Xiaoqiao
> Assignee: He Xiaoqiao
> Priority: Major
> Attachments: HDFS-14810.001.patch
>
>
> refactor and unified type of edit log sync in FSNamesystem as HDFS-11246
> mentioned.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
