[
https://issues.apache.org/jira/browse/HDDS-1843?focusedWorklogId=305360&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-305360
]
ASF GitHub Bot logged work on HDDS-1843:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/19 00:34
Start Date: 03/Sep/19 00:34
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1364: HDDS-1843.
Undetectable corruption after restart of a datanode.
URL: https://github.com/apache/hadoop/pull/1364#issuecomment-527263446
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 36 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 4 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 25 | Maven dependency ordering for branch |
| +1 | mvninstall | 580 | trunk passed |
| +1 | compile | 406 | trunk passed |
| +1 | checkstyle | 72 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 908 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 175 | trunk passed |
| 0 | spotbugs | 473 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 693 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 37 | Maven dependency ordering for patch |
| +1 | mvninstall | 609 | the patch passed |
| +1 | compile | 399 | the patch passed |
| +1 | cc | 399 | the patch passed |
| +1 | javac | 399 | the patch passed |
| -0 | checkstyle | 37 | hadoop-hdds: The patch generated 2 new + 0
unchanged - 0 fixed = 2 total (was 0) |
| -0 | checkstyle | 41 | hadoop-ozone: The patch generated 4 new + 0
unchanged - 0 fixed = 4 total (was 0) |
| +1 | mvnsite | 0 | the patch passed |
| -1 | whitespace | 0 | The patch has 25 line(s) that end in whitespace. Use
git apply --whitespace=fix <<patch_file>>. Refer
https://git-scm.com/docs/git-apply |
| +1 | shadedclient | 643 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 177 | the patch passed |
| -1 | findbugs | 234 | hadoop-hdds generated 1 new + 0 unchanged - 0 fixed
= 1 total (was 0) |
||| _ Other Tests _ |
| +1 | unit | 275 | hadoop-hdds in the patch passed. |
| -1 | unit | 2571 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 54 | The patch does not generate ASF License warnings. |
| | | 8591 | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-hdds |
| |
org.apache.hadoop.ozone.container.common.impl.HddsDispatcher.dispatchRequest(ContainerProtos$ContainerCommandRequestProto,
DispatcherContext) invokes inefficient new Long(long) constructor; use
Long.valueOf(long) instead At HddsDispatcher.java:Long(long) constructor; use
Long.valueOf(long) instead At HddsDispatcher.java:[line 241] |
| Failed junit tests | hadoop.ozone.TestContainerOperations |
| | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException |
| | hadoop.ozone.scm.TestGetCommittedBlockLengthAndPutKey |
| | hadoop.ozone.scm.TestXceiverClientManager |
| | hadoop.ozone.TestContainerStateMachineIdempotency |
| | hadoop.ozone.om.TestSecureOzoneManager |
| | hadoop.ozone.container.metrics.TestContainerMetrics |
| | hadoop.ozone.container.ozoneimpl.TestOzoneContainer |
| | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures |
| | hadoop.ozone.scm.TestXceiverClientMetrics |
| | hadoop.ozone.scm.TestContainerSmallFile |
| | hadoop.ozone.client.rpc.Test2WayCommitInRatis |
| | hadoop.ozone.container.TestContainerReplication |
| |
hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1364 |
| Optional Tests | dupname asflicense compile cc mvnsite javac unit javadoc
mvninstall shadedclient findbugs checkstyle |
| uname | Linux 23e0b2fdc078 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 915cbc9 |
| Default Java | 1.8.0_222 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/artifact/out/diff-checkstyle-hadoop-hdds.txt
|
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/artifact/out/diff-checkstyle-hadoop-ozone.txt
|
| whitespace |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/artifact/out/whitespace-eol.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/artifact/out/new-findbugs-hadoop-hdds.html
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/testReport/ |
| Max. process+thread count | 5320 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-hdds/container-service
hadoop-ozone/integration-test U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1364/4/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 305360)
Time Spent: 5h (was: 4h 50m)
> Undetectable corruption after restart of a datanode
> ---------------------------------------------------
>
> Key: HDDS-1843
> URL: https://issues.apache.org/jira/browse/HDDS-1843
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode
> Affects Versions: 0.5.0
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Critical
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Attachments: HDDS-1843.000.patch
>
> Time Spent: 5h
> Remaining Estimate: 0h
>
> Right now, all write chunks use BufferedIO ie, sync flag is disabled by
> default. Also, Rocks Db metadata updates are done in Rocks DB cache first at
> Datanode. In case, there comes a situation where the buffered chunk data as
> well as the corresponding metadata update is lost as a part of datanode
> restart, it may lead to a situation where, it will not be possible to detect
> the corruption (not even with container scanner) of this nature in a
> reasonable time frame, until and unless there is a client IO failure or Recon
> server detects it over time. In order to atleast to detect the problem, Ratis
> snapshot on datanode should sync the rocks db file . In such a way,
> ContainerScanner will be able to detect this.We can also add a metric around
> sync to measure how much of a throughput loss it can incurr.
> Thanks [~msingh] for suggesting this.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
