[ 
https://issues.apache.org/jira/browse/HDFS-14801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16921106#comment-16921106
 ] 

Akira Ajisaka commented on HDFS-14801:
--------------------------------------

Attached a screenshot.
After the patch, we can query NNTopMetrics by windowMs, op, or user.

This change is only in PrometheusMetricsSink. PrometheusMetricsSink is not yet 
released, so now we can break compatibility.

TODO:
Old metrics are still exposed via '/prom' endpoint. We have to clear metrics if 
there are no updates within the windowMs.

> PrometheusMetricsSink: Better support for NNTop
> -----------------------------------------------
>
>                 Key: HDFS-14801
>                 URL: https://issues.apache.org/jira/browse/HDFS-14801
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: metrics
>            Reporter: Akira Ajisaka
>            Assignee: Akira Ajisaka
>            Priority: Major
>         Attachments: Screen Shot 2019-09-03 at 10.28.46.png
>
>
> Now nntop metrics is flattened as 
> dfs.NNTopUserOpCounts.windowMs=<windowMs>.op=<op>.user=<user>.count.
> I'd like to make windowMs, op, and user as label instead of name for more 
> prometheus-friendly metrics.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to