[
https://issues.apache.org/jira/browse/HDDS-1553?focusedWorklogId=305912&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-305912
]
ASF GitHub Bot logged work on HDDS-1553:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Sep/19 21:30
Start Date: 03/Sep/19 21:30
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1361: HDDS-1553.
Add metrics in rack aware container placement policy.
URL: https://github.com/apache/hadoop/pull/1361#discussion_r320486867
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/placement/algorithms/SCMPlacementMetrics.java
##########
@@ -0,0 +1,107 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hdds.scm.container.placement.algorithms;
+
+import com.google.common.annotations.VisibleForTesting;
+import org.apache.hadoop.metrics2.MetricsCollector;
+import org.apache.hadoop.metrics2.MetricsInfo;
+import org.apache.hadoop.metrics2.MetricsSource;
+import org.apache.hadoop.metrics2.MetricsSystem;
+import org.apache.hadoop.metrics2.annotation.Metric;
+import org.apache.hadoop.metrics2.annotation.Metrics;
+import org.apache.hadoop.metrics2.lib.DefaultMetricsSystem;
+import org.apache.hadoop.metrics2.lib.Interns;
+import org.apache.hadoop.metrics2.lib.MetricsRegistry;
+import org.apache.hadoop.metrics2.lib.MutableCounterLong;
+
+/**
+ * This class is for maintaining Topology aware placement statistics.
+ */
+@Metrics(about="SCM Placement Metrics", context = "ozone")
+public class SCMPlacementMetrics implements MetricsSource {
+ public static final String SOURCE_NAME =
+ SCMPlacementMetrics.class.getSimpleName();
+ private static final MetricsInfo RECORD_INFO = Interns.info(SOURCE_NAME,
+ "SCM Placement Metrics");
+ private static MetricsRegistry registry;
+
+ // total datanode allocation request count
+ @Metric private MutableCounterLong datanodeRequestCount;
+ // datanode allocation tried count, including success, fallback and failed
+ @Metric private MutableCounterLong datanodeAllocationTryCount;
Review comment:
NIT: datanodeAllocationTryCount -> datanodeChooseAttemptCount
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 305912)
Time Spent: 2h (was: 1h 50m)
> Add metrics in rack aware container placement policy
> ----------------------------------------------------
>
> Key: HDDS-1553
> URL: https://issues.apache.org/jira/browse/HDDS-1553
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Sammi Chen
> Assignee: Sammi Chen
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2h
> Remaining Estimate: 0h
>
> To collect following statistics,
> 1. total requested datanode count (A)
> 2. success allocated datanode count without constrain compromise (B)
> 3. success allocated datanode count with some comstrain compromise (C)
> B includes C, failed allocation = (A - B)
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
