[
https://issues.apache.org/jira/browse/HDDS-1561?focusedWorklogId=306536&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-306536
]
ASF GitHub Bot logged work on HDDS-1561:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/19 17:10
Start Date: 04/Sep/19 17:10
Worklog Time Spent: 10m
Work Description: nandakumar131 commented on pull request #1401:
HDDS-1561: Mark OPEN containers as QUASI_CLOSED as part of Ratis groupRemove
URL: https://github.com/apache/hadoop/pull/1401#discussion_r320873889
##########
File path:
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
##########
@@ -800,6 +805,24 @@ public void notifyLogFailed(Throwable t, LogEntryProto
failedEntry) {
return future;
}
+ @Override
+ public void notifyGroupRemove() {
+ ratisServer.notifyGroupRemove(gid);
+ // Make best effort to quasi-close all the containers on group removal.
+ // Containers already in terminal state like CLOSED or UNHEALTHY will not
+ // be affected.
+ for (Long cid : createContainerSet) {
+ try {
+ containerController.markContainerForClose(cid);
+ } catch (IOException e) {
+ }
+ try {
+ containerController.quasiCloseContainer(cid);
+ } catch (IOException e) {
+ }
+ }
+ }
+
Review comment:
If markContainerForClose fails, quasiCloseContainer will definitely fail. We
can put both of the calls into same try catch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 306536)
Remaining Estimate: 0h
Time Spent: 10m
> Mark OPEN containers as QUASI_CLOSED as part of Ratis groupRemove
> -----------------------------------------------------------------
>
> Key: HDDS-1561
> URL: https://issues.apache.org/jira/browse/HDDS-1561
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Datanode, SCM
> Affects Versions: 0.3.0
> Reporter: Mukul Kumar Singh
> Assignee: Lokesh Jain
> Priority: Blocker
> Labels: pull-request-available
> Attachments: HDDS-1561.001.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Right now, if a pipeline is destroyed by SCM, all the container on the
> pipeline are marked as quasi closed when datanode received close container
> command. SCM while processing these containers reports, marks these
> containers as closed once majority of the nodes are available.
> This is however not a sufficient condition in cases where the raft log
> directory is missing or corrupted. As the containers will not have all the
> applied transaction.
> To solve this problem, we should QUASI_CLOSE the containers in datanode as
> part of ratis groupRemove. If a container is in OPEN state in datanode
> without any active pipeline, it will be marked as Unhealthy while processing
> close container command.
> cc [~jnp], [~shashikant], [~sdeka], [~nandakumar131]
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
