[
https://issues.apache.org/jira/browse/HDDS-1982?focusedWorklogId=306753&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-306753
]
ASF GitHub Bot logged work on HDDS-1982:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Sep/19 22:24
Start Date: 04/Sep/19 22:24
Worklog Time Spent: 10m
Work Description: anuengineer commented on pull request #1344: HDDS-1982
Extend SCMNodeManager to support decommission and maintenance states
URL: https://github.com/apache/hadoop/pull/1344#discussion_r320999602
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java
##########
@@ -151,7 +152,9 @@ private void unregisterMXBean() {
*/
@Override
public List<DatanodeDetails> getNodes(NodeState nodestate) {
- return nodeStateManager.getNodes(nodestate).stream()
+ return nodeStateManager.getNodes(
+ new NodeStatus(HddsProtos.NodeOperationalState.IN_SERVICE, nodestate))
+ .stream()
.map(node -> (DatanodeDetails)node).collect(Collectors.toList());
}
Review comment:
In the final patch, should change the Node Query Function? so we can say,
get me all the nodes that are in service and healthy, or all nodes in
maintenance mode but dead? Let us Add that feature when we need it. I am ok
with all operations mapping to IN_SERVICE for now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 306753)
> Extend SCMNodeManager to support decommission and maintenance states
> --------------------------------------------------------------------
>
> Key: HDDS-1982
> URL: https://issues.apache.org/jira/browse/HDDS-1982
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: SCM
> Reporter: Stephen O'Donnell
> Assignee: Stephen O'Donnell
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Currently, within SCM a node can have the following states:
> HEALTHY
> STALE
> DEAD
> DECOMMISSIONING
> DECOMMISSIONED
> The last 2 are not currently used.
> In order to support decommissioning and maintenance mode, we need to extend
> the set of states a node can have to include decommission and maintenance
> states.
> It is also important to note that a node decommissioning or entering
> maintenance can also be HEALTHY, STALE or go DEAD.
> Therefore in this Jira I propose we should model a node state with two
> different sets of values. The first, is effectively the liveliness of the
> node, with the following states. This is largely what is in place now:
> HEALTHY
> STALE
> DEAD
> The second is the node operational state:
> IN_SERVICE
> DECOMMISSIONING
> DECOMMISSIONED
> ENTERING_MAINTENANCE
> IN_MAINTENANCE
> That means the overall total number of states for a node is the cross-product
> of the two above lists, however it probably makes sense to keep the two
> states seperate internally.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
