[
https://issues.apache.org/jira/browse/HDDS-2053?focusedWorklogId=307423&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-307423
]
ASF GitHub Bot logged work on HDDS-2053:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Sep/19 20:44
Start Date: 05/Sep/19 20:44
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1373: HDDS-2053.
Fix TestOzoneManagerRatisServer failure. Contributed by Xi…
URL: https://github.com/apache/hadoop/pull/1373#discussion_r321472474
##########
File path:
hadoop-ozone/ozone-manager/src/test/java/org/apache/hadoop/ozone/om/ratis/TestOzoneManagerRatisServer.java
##########
@@ -205,6 +205,7 @@ public void
verifyRaftGroupIdGenerationWithCustomOmServiceId() throws
.setOMServiceId(customOmServiceId)
.build();
// Starts a single node Ratis server
+ omRatisServer.stop();
OzoneManagerRatisServer newOmRatisServer = OzoneManagerRatisServer
Review comment:
@ChenSammi omRatisServer is started at the begin of each test case and stop
after that. However in this new test case, it started a different
OzoneManagerRatisServer named newOmRatisServer, it has to be stopped explicitly
to avoid leak. Also, the omRatisServer has to be stopped before
newOmRatisServer is started to avoid metric registration confliction.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 307423)
Time Spent: 2.5h (was: 2h 20m)
> Fix TestOzoneManagerRatisServer failure
> ---------------------------------------
>
> Key: HDDS-2053
> URL: https://issues.apache.org/jira/browse/HDDS-2053
> Project: Hadoop Distributed Data Store
> Issue Type: Test
> Reporter: Xiaoyu Yao
> Assignee: Xiaoyu Yao
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
