[
https://issues.apache.org/jira/browse/HDDS-1982?focusedWorklogId=308006&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308006
]
ASF GitHub Bot logged work on HDDS-1982:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/19 16:43
Start Date: 06/Sep/19 16:43
Worklog Time Spent: 10m
Work Description: anuengineer commented on pull request #1344: HDDS-1982
Extend SCMNodeManager to support decommission and maintenance states
URL: https://github.com/apache/hadoop/pull/1344#discussion_r321819701
##########
File path:
hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/states/NodeStateMap.java
##########
@@ -43,7 +45,7 @@
/**
* Represents the current state of node.
*/
- private final ConcurrentHashMap<NodeState, Set<UUID>> stateMap;
+ private final ConcurrentHashMap<UUID, NodeStatus> stateMap;
Review comment:
even if you have 15x states, the number of nodes is less. if you have 100
nodes, there are only 1500 states, and if you have 1000 nodes, it is 15000
states. It is still trivial to keep these in memory. Here is the real kicker,
just like we decided not to write all cross products for the NodeState static
functions, we will end up needing lists of only frequently accessed pattern (in
mind that would be (in_service, healthy). All other node queries can be
retrieved by iterating the lists as needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 308006)
Time Spent: 4h 10m (was: 4h)
> Extend SCMNodeManager to support decommission and maintenance states
> --------------------------------------------------------------------
>
> Key: HDDS-1982
> URL: https://issues.apache.org/jira/browse/HDDS-1982
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: SCM
> Reporter: Stephen O'Donnell
> Assignee: Stephen O'Donnell
> Priority: Major
> Labels: pull-request-available
> Time Spent: 4h 10m
> Remaining Estimate: 0h
>
> Currently, within SCM a node can have the following states:
> HEALTHY
> STALE
> DEAD
> DECOMMISSIONING
> DECOMMISSIONED
> The last 2 are not currently used.
> In order to support decommissioning and maintenance mode, we need to extend
> the set of states a node can have to include decommission and maintenance
> states.
> It is also important to note that a node decommissioning or entering
> maintenance can also be HEALTHY, STALE or go DEAD.
> Therefore in this Jira I propose we should model a node state with two
> different sets of values. The first, is effectively the liveliness of the
> node, with the following states. This is largely what is in place now:
> HEALTHY
> STALE
> DEAD
> The second is the node operational state:
> IN_SERVICE
> DECOMMISSIONING
> DECOMMISSIONED
> ENTERING_MAINTENANCE
> IN_MAINTENANCE
> That means the overall total number of states for a node is the cross-product
> of the two above lists, however it probably makes sense to keep the two
> states seperate internally.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
