[
https://issues.apache.org/jira/browse/HDDS-2007?focusedWorklogId=308153&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-308153
]
ASF GitHub Bot logged work on HDDS-2007:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Sep/19 20:48
Start Date: 06/Sep/19 20:48
Worklog Time Spent: 10m
Work Description: smengcl commented on pull request #1360: HDDS-2007.
Make ozone fs shell command work with OM HA service ids
URL: https://github.com/apache/hadoop/pull/1360#discussion_r321904661
##########
File path:
hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/OzoneClientFactory.java
##########
@@ -136,6 +136,31 @@ public static OzoneClient getRpcClient(String omHost,
Integer omRpcPort,
return getRpcClient(config);
}
+ /**
+ * Returns an OzoneClient which will use RPC protocol.
+ *
+ * @param omServiceId
+ * Service ID of OzoneManager HA cluster.
+ *
+ * @param config
+ * Configuration to be used for OzoneClient creation
+ *
+ * @return OzoneClient
+ *
+ * @throws IOException
+ */
+ public static OzoneClient getRpcClient(String omServiceId,
+ Configuration config)
+ throws IOException {
+ Preconditions.checkNotNull(omServiceId);
+ Preconditions.checkNotNull(config);
+ // Override ozone.om.address just in case it is used later.
+ // Because if this is not overridden, the (incorrect) value from xml
+ // will be used?
+ config.set(OZONE_OM_ADDRESS_KEY, omServiceId);
Review comment:
As discussed, I will remove this one. Thanks for pointing out!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 308153)
Time Spent: 2.5h (was: 2h 20m)
> Make ozone fs shell command work with OM HA service ids
> -------------------------------------------------------
>
> Key: HDDS-2007
> URL: https://issues.apache.org/jira/browse/HDDS-2007
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: Ozone Client
> Reporter: Siyao Meng
> Assignee: Siyao Meng
> Priority: Major
> Labels: pull-request-available
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Build an HDFS HA-like nameservice for OM HA so that Ozone client can access
> Ozone HA cluster with ease.
> The majority of the work is already done in HDDS-972. But the problem is that
> the client would crash if there are more than one service ids
> (ozone.om.service.ids) configured in ozone-site.xml. This need to be address
> on client side.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
