[ 
https://issues.apache.org/jira/browse/HDFS-14754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16924916#comment-16924916
 ] 

Ayush Saxena commented on HDFS-14754:
-------------------------------------

Thanx [~hemanthboyina] for the patch and [~surendrasingh] for the review..
bq. Replicated block was not deleting and missing block is not able to 
ReConstruct.
HDFS-14699 seems to be handling a quite similar scenario. Whether post that 
gets in, still this problem be there. Whether reconstruction will still not 
happen, without this?  [~hemanthboyina] can you give  a check once.
Anyway on a quick look, For the UT,  Can you add some comments regarding what 
actually the process you are trying to validate, for better undesirability. 

{code:java}
+    int i = 0;
+    // one missing block
+    for (; i < groupSize - 1; i++)
{code}

Any reasons for making i out?


{code:java}
+    cluster.triggerBlockReports();
+    cluster.triggerHeartbeats();
+    cluster.triggerHeartbeats();
+    cluster.triggerBlockReports();
{code}

Can you add a line explaining why it is required twice, here.


> Erasure Coding :  The number of Under-Replicated Blocks never reduced
> ---------------------------------------------------------------------
>
>                 Key: HDFS-14754
>                 URL: https://issues.apache.org/jira/browse/HDFS-14754
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: hemanthboyina
>            Assignee: hemanthboyina
>            Priority: Critical
>         Attachments: HDFS-14754.001.patch, HDFS-14754.002.patch, 
> HDFS-14754.003.patch, HDFS-14754.004.patch, HDFS-14754.005.patch, 
> HDFS-14754.006.patch
>
>
> Using EC RS-3-2, 6 DNĀ 
> We came accross a scenario where in the EC 5 blocks , same block is 
> replicated thrice and two blocks got missing
> Replicated block was not deleting and missing block is not able to ReConstruct



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to