[
https://issues.apache.org/jira/browse/HDFS-14798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16925163#comment-16925163
]
David Mollitor commented on HDFS-14798:
---------------------------------------
Hello [~ayushtkn],
Thank you for the feedback.
I do not think the law of "premature optimization" applies to this case. This
issue is not about optimization, in the general sense of performance. This
issue is about shoring up a potential landmine before it hits in a production
system. Better to catch this potential issue in a static code review than in a
live system.
> Synchronize invalidateBlocks in DatanodeDescriptor
> --------------------------------------------------
>
> Key: HDFS-14798
> URL: https://issues.apache.org/jira/browse/HDFS-14798
> Project: Hadoop HDFS
> Issue Type: Bug
> Components: namenode
> Affects Versions: 3.2.0
> Reporter: David Mollitor
> Assignee: hemanthboyina
> Priority: Minor
> Labels: n00b, newbie
> Attachments: HDFS-14798.001.patch
>
>
> {code:java|title=DatanodeDescriptor.java}
> public void resetBlocks() {
> ...
> this.invalidateBlocks.clear();
> ...
> }
> public void clearBlockQueues() {
> synchronized (invalidateBlocks) {
> this.invalidateBlocks.clear();
> }
> ...
> }
> {code}
> It may not be strictly necessary, but why risk it? The invalidateBlocks
> should be protected in {{resetBlocks()}} just like it is in
> {{clearBlockQueues()}}/
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
