ASF GitHub Bot logged work on HDDS-1786:

                Author: ASF GitHub Bot
            Created on: 10/Sep/19 08:10
            Start Date: 10/Sep/19 08:10
    Worklog Time Spent: 10m 
      Work Description: bshashikant commented on issue #1163: HDDS-1786 : 
Datanodes takeSnapshot should delete previously created s…
URL: https://github.com/apache/hadoop/pull/1163#issuecomment-529824132
   Thanks @avijayanhwx for working on this. The changes look good. 
   I think it would be better to move all configs related to RaftServer under 
the RaftServerConfig group but that's beyond the scope of this jira.
   I would prefer to have a test in Ozone as well to verify the snapshot 
retention behaviour of Ratis so that, in case there are changes made in Ratis 
related to this, we should be able to catch this here in ozone.
   A simple unit test where can change snapshot threshold to 1 entry and verify 
we have n snapshot files after n transactions in the raft log directory.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 309610)
    Time Spent: 3h 10m  (was: 3h)

> Datanodes takeSnapshot should delete previously created snapshots
> -----------------------------------------------------------------
>                 Key: HDDS-1786
>                 URL: https://issues.apache.org/jira/browse/HDDS-1786
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Datanode
>    Affects Versions: 0.4.0
>            Reporter: Mukul Kumar Singh
>            Assignee: Aravindan Vijayan
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 3h 10m
>  Remaining Estimate: 0h
> Right now, after after taking a new snapshot, the previous snapshot file is 
> left in the raft log directory. When a new snapshot is taken, the previous 
> snapshots should be deleted.

This message was sent by Atlassian Jira

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to