[
https://issues.apache.org/jira/browse/HDDS-2032?focusedWorklogId=309683&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-309683
]
ASF GitHub Bot logged work on HDDS-2032:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Sep/19 10:27
Start Date: 10/Sep/19 10:27
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1420: HDDS-2032. Ozone
client should retry writes in case of any ratis/stateMachine exceptions.
URL: https://github.com/apache/hadoop/pull/1420#issuecomment-529874167
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 32 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 67 | Maven dependency ordering for branch |
| +1 | mvninstall | 716 | trunk passed |
| +1 | compile | 391 | trunk passed |
| +1 | checkstyle | 73 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 941 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 166 | trunk passed |
| 0 | spotbugs | 518 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 750 | trunk passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 33 | Maven dependency ordering for patch |
| +1 | mvninstall | 549 | the patch passed |
| +1 | compile | 384 | the patch passed |
| +1 | javac | 384 | the patch passed |
| +1 | checkstyle | 76 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 731 | patch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 165 | the patch passed |
| -1 | findbugs | 233 | hadoop-hdds generated 2 new + 0 unchanged - 0 fixed
= 2 total (was 0) |
||| _ Other Tests _ |
| +1 | unit | 278 | hadoop-hdds in the patch passed. |
| -1 | unit | 2567 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 42 | The patch does not generate ASF License warnings. |
| | | 8828 | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-hdds |
| | Load of known null value in
org.apache.hadoop.hdds.scm.client.HddsClientUtils.checkForException(Exception)
At HddsClientUtils.java:in
org.apache.hadoop.hdds.scm.client.HddsClientUtils.checkForException(Exception)
At HddsClientUtils.java:[line 327] |
| | Redundant nullcheck of t which is known to be null in
org.apache.hadoop.hdds.scm.client.HddsClientUtils.checkForException(Exception)
Redundant null check at HddsClientUtils.java:is known to be null in
org.apache.hadoop.hdds.scm.client.HddsClientUtils.checkForException(Exception)
Redundant null check at HddsClientUtils.java:[line 327] |
| Failed junit tests | hadoop.ozone.container.TestContainerReplication |
| |
hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion |
| | hadoop.ozone.client.rpc.TestBlockOutputStream |
| | hadoop.ozone.scm.TestContainerSmallFile |
| | hadoop.ozone.TestSecureOzoneCluster |
| | hadoop.ozone.client.rpc.TestMultiBlockWritesWithDnFailures |
| | hadoop.ozone.om.TestOzoneManagerHA |
| | hadoop.ozone.client.rpc.TestBlockOutputStreamWithFailures |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1420/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1420 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux dc4b83c91d1e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / bc2d3a7 |
| Default Java | 1.8.0_222 |
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1420/1/artifact/out/new-findbugs-hadoop-hdds.html
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1420/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1420/1/testReport/ |
| Max. process+thread count | 4598 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/client hadoop-ozone/client U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1420/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 309683)
Time Spent: 20m (was: 10m)
> Ozone client should retry writes in case of any ratis/stateMachine exceptions
> -----------------------------------------------------------------------------
>
> Key: HDDS-2032
> URL: https://issues.apache.org/jira/browse/HDDS-2032
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Client
> Affects Versions: 0.5.0
> Reporter: Shashikant Banerjee
> Assignee: Shashikant Banerjee
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.5.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, Ozone client retry writes on a different pipeline or container in
> case of some specific exceptions. But in case, it sees exception such as
> DISK_FULL, CONTAINER_UNHEALTHY or any corruption , it just aborts the write.
> In general, the every such exception on the client should be a retriable
> exception in ozone client and on some specific exceptions, it should take
> some more specific exception like excluding certain containers or pipelines
> while retrying or informing SCM of a corrupt replica etc.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
