[ 
https://issues.apache.org/jira/browse/HDDS-2007?focusedWorklogId=310065&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-310065
 ]

ASF GitHub Bot logged work on HDDS-2007:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Sep/19 19:51
            Start Date: 10/Sep/19 19:51
    Worklog Time Spent: 10m 
      Work Description: bharatviswa504 commented on pull request #1360: 
HDDS-2007. Make ozone fs shell command work with OM HA service ids      
URL: https://github.com/apache/hadoop/pull/1360#discussion_r322930998
 
 

 ##########
 File path: 
hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java
 ##########
 @@ -131,6 +142,13 @@ public void initialize(URI name, Configuration conf) 
throws IOException {
         // If port number is not specified, read it from config
         omPort = OmUtils.getOmRpcPort(conf);
       }
+    } else if (OmUtils.isServiceIdsDefined(conf)) {
 
 Review comment:
   
https://github.com/apache/hadoop/blob/trunk/hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneFileSystem.java#L154
 
   This is code line calling creation of BasicOzoneClientAdapterImpl. And below 
is the code where it checks if conf passed is instance of OzoneConfiguration or 
not, if not convert to OzoneConfiguration object.
   
   
https://github.com/apache/hadoop/blob/trunk/hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/BasicOzoneClientAdapterImpl.java#L112
   
   
    
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 310065)
    Time Spent: 4h 20m  (was: 4h 10m)

> Make ozone fs shell command work with OM HA service ids
> -------------------------------------------------------
>
>                 Key: HDDS-2007
>                 URL: https://issues.apache.org/jira/browse/HDDS-2007
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: Ozone Client
>            Reporter: Siyao Meng
>            Assignee: Siyao Meng
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> Build an HDFS HA-like nameservice for OM HA so that Ozone client can access 
> Ozone HA cluster with ease.
> The majority of the work is already done in HDDS-972. But the problem is that 
> the client would crash if there are more than one service ids 
> (ozone.om.service.ids) configured in ozone-site.xml. This need to be address 
> on client side.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to