[
https://issues.apache.org/jira/browse/HDFS-14836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928173#comment-16928173
]
Aiphago commented on HDFS-14836:
--------------------------------
Thanks [~jojochuang] for the comment.
{quote}it would be the best if we can avoid string-matching exception messages.
"Broken pipe" and "Connection reset" are usually thrown as a SocketException.
Would it make sense to check exception class name instead? Better, catch
SocketException and do not call onFailure().
{quote}
if we just check exception class name instead, the range maybe too big.I means
maybe there are some other SocketException and not match "Broken pipe" and
"Connection reset" .So why we not keep consistency to -HDFS-2054 .-
{quote}for socket related exceptions, you don't want to call onFailure();
however, those exceptions should be re-thrown too. They should not be ignored
silently.
{quote}
it's a good suggestion,I will change later.
> FileIoProvider should not increase FileIoErrors metric in datanode volume
> metric
> --------------------------------------------------------------------------------
>
> Key: HDFS-14836
> URL: https://issues.apache.org/jira/browse/HDFS-14836
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Aiphago
> Assignee: Aiphago
> Priority: Minor
> Attachments: HDFS-14836.patch
>
>
> I found that FileIoErrors metric will increase in
> BlockSender.sendPacket(),when use fileIoProvider.transferToSocketFully().But
> in https://issues.apache.org/jira/browse/HDFS-2054 the Exception has been
> ignore like "Broken pipe" and "Connection reset" .
> So should do a filter when fileIoProvider increase FileIoErrors count ?
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
