ASF GitHub Bot logged work on HDDS-2110:

                Author: ASF GitHub Bot
            Created on: 14/Sep/19 04:51
            Start Date: 14/Sep/19 04:51
    Worklog Time Spent: 10m 
      Work Description: anuengineer commented on issue #1448: HDDS-2110. 
Arbitrary file can be downloaded with the help of ProfilerServlet
URL: https://github.com/apache/hadoop/pull/1448#issuecomment-531448967
   +1, pending Jenkins. 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 312499)
    Time Spent: 20m  (was: 10m)

> Arbitrary file can be downloaded with the help of ProfilerServlet
> -----------------------------------------------------------------
>                 Key: HDDS-2110
>                 URL: https://issues.apache.org/jira/browse/HDDS-2110
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Native
>            Reporter: Aayush
>            Assignee: Elek, Marton
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 20m
>  Remaining Estimate: 0h
> The LOC 324 in the file 
> [ProfileServlet.java|https://github.com/apache/hadoop/blob/217bdbd940a96986df3b96899b43caae2b5a9ed2/hadoop-hdds/framework/src/main/java/org/apache/hadoop/hdds/server/ProfileServlet.java]
>  is prone to an arbitrary file download:-
> {code:java}
> protected void doGetDownload(String fileName, final HttpServletRequest req,   
>    final HttpServletResponse resp) throws IOException {
> File requestedFile = 
> ProfileServlet.OUTPUT_DIR.resolve(fileName).toAbsolutePath().toFile();{code}
> As the String fileName is directly considered as the requested file.
> Which is called at LOC 180 with HTTP request directly passed:-
> {code:java}
> if (req.getParameter("file") != null) {      
> doGetDownload(req.getParameter("file"), req, resp);      
> return;    
> }
> {code}

This message was sent by Atlassian Jira

To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to