[ 
https://issues.apache.org/jira/browse/HDFS-14849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16929912#comment-16929912
 ] 

Ayush Saxena edited comment on HDFS-14849 at 9/15/19 6:16 AM:
--------------------------------------------------------------

Thanx [~marvelrock] for the patch, Got the change. The decommissioned one gets 
added first and then when the live one comes, it is marked as redundant. Seems 
fair enough to check state first. Fix LGTM. if there aren't any test failures!!!

For the test :

{code:java}
    // ec policy
756         ECSchema rsSchema = new ECSchema("rs", 3, 2);
757         String policyName = "RS-3-2-128k";
758         int cellSize = 128 * 1024;
759         ErasureCodingPolicy ecPolicy =
760             new ErasureCodingPolicy(policyName, rsSchema, cellSize, (byte) 
-1);

{code}

You may instead use directly :


{code:java}
    // RS-3-2 EC policy
    ErasureCodingPolicy ecPolicy =
        SystemErasureCodingPolicies.getPolicies().get(1);
{code}
 
Anyway it would be good, if you add some more details in the description


was (Author: ayushtkn):
Thanx [~marvelrock] for the patch, Got the change. The decommissioned one gets 
added first and then when the live one comes, it is marked as redundant. Seems 
fair enough to check state first. Fix LGTM.

For the test :

{code:java}
    // ec policy
756         ECSchema rsSchema = new ECSchema("rs", 3, 2);
757         String policyName = "RS-3-2-128k";
758         int cellSize = 128 * 1024;
759         ErasureCodingPolicy ecPolicy =
760             new ErasureCodingPolicy(policyName, rsSchema, cellSize, (byte) 
-1);

{code}

You may instead use directly :


{code:java}
    // RS-3-2 EC policy
    ErasureCodingPolicy ecPolicy =
        SystemErasureCodingPolicies.getPolicies().get(1);
{code}
 

> Erasure Coding: replicate block infinitely when datanode being decommissioning
> ------------------------------------------------------------------------------
>
>                 Key: HDFS-14849
>                 URL: https://issues.apache.org/jira/browse/HDFS-14849
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 3.3.0
>            Reporter: HuangTao
>            Assignee: HuangTao
>            Priority: Major
>              Labels: EC, HDFS, NameNode
>         Attachments: HDFS-14849.001.patch
>
>
> When the datanode keeping in DECOMMISSION_INPROGRESS status, the EC block in 
> that datanode will be replicated infinitely.



--
This message was sent by Atlassian Jira
(v8.3.2#803003)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to