[
https://issues.apache.org/jira/browse/HDFS-14833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16931828#comment-16931828
]
Íñigo Goiri commented on HDFS-14833:
------------------------------------
* In RouterAdminServer#updateMountTableEntry(), I would move {{MountTable
mountTable = request.getEntry();}} to the very beginning and use that value in
the {{getMountPoint()}}. Probably call it {{updateEntry}} like in the other
method.
* I like the {{oldEntry}} naming. Easier to read now.
* Extract RouterAdminServer#348 a little. Too many chain getters make it hard
to read.
* If we are going to merge ifs, at some point we should have a function for
{{nsQuota != HdfsConstants.QUOTA_DONT_SET || ssQuota !=
HdfsConstants.QUOTA_DONT_SET}}. Otherwise we could separate the {{if
(router.isQuotaEnabled())}}.
> RBF: Router Update Doesn't Sync Quota
> -------------------------------------
>
> Key: HDFS-14833
> URL: https://issues.apache.org/jira/browse/HDFS-14833
> Project: Hadoop HDFS
> Issue Type: Sub-task
> Reporter: Ayush Saxena
> Assignee: Ayush Saxena
> Priority: Major
> Attachments: HDFS-14833-01.patch, HDFS-14833-02.patch,
> HDFS-14833-03.patch, HDFS-14833-04.patch
>
>
> HDFS-14777 Added a check to prevent RPC call, It checks whether in the
> present state whether quota is changing.
> But ignores the part that if the locations are changed. if the location is
> changed the new destination should be synchronized with the mount entry
> quota.
--
This message was sent by Atlassian Jira
(v8.3.2#803003)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
