[
https://issues.apache.org/jira/browse/HDDS-2034?focusedWorklogId=314635&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314635
]
ASF GitHub Bot logged work on HDDS-2034:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Sep/19 20:41
Start Date: 18/Sep/19 20:41
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1469: HDDS-2034. Async
RATIS pipeline creation and destroy through heartbea…
URL: https://github.com/apache/hadoop/pull/1469#issuecomment-532857571
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 59 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 2 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 12 new or modified test
files. |
||| _ HDDS-1564 Compile Tests _ |
| 0 | mvndep | 31 | Maven dependency ordering for branch |
| +1 | mvninstall | 732 | HDDS-1564 passed |
| +1 | compile | 455 | HDDS-1564 passed |
| +1 | checkstyle | 82 | HDDS-1564 passed |
| +1 | mvnsite | 0 | HDDS-1564 passed |
| +1 | shadedclient | 1059 | branch has no errors when building and testing
our client artifacts. |
| +1 | javadoc | 199 | HDDS-1564 passed |
| 0 | spotbugs | 505 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| +1 | findbugs | 739 | HDDS-1564 passed |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 39 | Maven dependency ordering for patch |
| +1 | mvninstall | 678 | the patch passed |
| +1 | compile | 444 | the patch passed |
| +1 | cc | 444 | the patch passed |
| +1 | javac | 444 | the patch passed |
| -0 | checkstyle | 41 | hadoop-hdds: The patch generated 10 new + 0
unchanged - 0 fixed = 10 total (was 0) |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | xml | 2 | The patch has no ill-formed XML file. |
| +1 | shadedclient | 848 | patch has no errors when building and testing
our client artifacts. |
| -1 | javadoc | 88 | hadoop-hdds generated 2 new + 16 unchanged - 0 fixed =
18 total (was 16) |
| -1 | findbugs | 254 | hadoop-hdds generated 3 new + 0 unchanged - 0 fixed
= 3 total (was 0) |
||| _ Other Tests _ |
| -1 | unit | 322 | hadoop-hdds in the patch failed. |
| -1 | unit | 1267 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 46 | The patch does not generate ASF License warnings. |
| | | 8284 | |
| Reason | Tests |
|-------:|:------|
| FindBugs | module:hadoop-hdds |
| | Null pointer dereference of dn in
org.apache.hadoop.hdds.scm.pipeline.SCMPipelineManager.onMessage(CommandStatusReportHandler$CreatePipelineStatus,
EventPublisher) Dereferenced at SCMPipelineManager.java:in
org.apache.hadoop.hdds.scm.pipeline.SCMPipelineManager.onMessage(CommandStatusReportHandler$CreatePipelineStatus,
EventPublisher) Dereferenced at SCMPipelineManager.java:[line 483] |
| | Load of known null value in
org.apache.hadoop.hdds.scm.pipeline.SCMPipelineManager.onMessage(CommandStatusReportHandler$CreatePipelineStatus,
EventPublisher) At SCMPipelineManager.java:in
org.apache.hadoop.hdds.scm.pipeline.SCMPipelineManager.onMessage(CommandStatusReportHandler$CreatePipelineStatus,
EventPublisher) At SCMPipelineManager.java:[line 482] |
| | The method name
org.apache.hadoop.ozone.protocol.commands.CreatePipelineCommandStatus.SetCreatePipelineAck(StorageContainerDatanodeProtocolProtos$CreatePipelineACKProto)
doesn't start with a lower case letter At
CreatePipelineCommandStatus.java:start with a lower case letter At
CreatePipelineCommandStatus.java:[lines 42-43] |
| Failed junit tests | hadoop.hdds.scm.safemode.TestSCMSafeModeManager |
| |
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerHandler
|
| | hadoop.ozone.container.common.impl.TestContainerDeletionChoosingPolicy
|
| | hadoop.ozone.TestMiniOzoneCluster |
| | hadoop.ozone.dn.scrubber.TestDataScrubber |
| | hadoop.ozone.client.rpc.TestOzoneClientRetriesOnException |
| | hadoop.ozone.om.TestOmMetrics |
| | hadoop.hdds.scm.pipeline.TestPipelineStateManager |
| | hadoop.ozone.client.rpc.TestContainerStateMachineFailures |
| | hadoop.ozone.TestStorageContainerManager |
| | hadoop.ozone.ozShell.TestOzoneDatanodeShell |
| | hadoop.hdds.scm.pipeline.TestNode2PipelineMap |
| |
hadoop.ozone.container.common.statemachine.commandhandler.TestCloseContainerByPipeline
|
| | hadoop.ozone.om.snapshot.TestOzoneManagerSnapshotProvider |
| | hadoop.hdds.scm.pipeline.TestSCMPipelineManager |
| | hadoop.hdds.scm.pipeline.TestPipelineClose |
| | hadoop.ozone.web.client.TestKeysRatis |
| | hadoop.ozone.om.TestOmAcls |
| | hadoop.ozone.om.TestOzoneManagerRestart |
| | hadoop.ozone.om.TestKeyPurging |
| | hadoop.ozone.container.server.TestSecureContainerServer |
| | hadoop.ozone.om.TestScmSafeMode |
| | hadoop.hdds.scm.pipeline.TestSCMRestart |
| |
hadoop.ozone.container.common.statemachine.commandhandler.TestDeleteContainerHandler
|
| | hadoop.ozone.om.TestOMDbCheckpointServlet |
| | hadoop.ozone.ozShell.TestOzoneShell |
| | hadoop.hdds.scm.pipeline.TestNodeFailure |
| | hadoop.ozone.container.ozoneimpl.TestOzoneContainer |
| | hadoop.ozone.web.client.TestBuckets |
| | hadoop.ozone.web.TestOzoneRestWithMiniCluster |
| | hadoop.hdds.scm.pipeline.TestRatisPipelineCreateAndDestroy |
| | hadoop.ozone.om.TestOmInit |
| | hadoop.ozone.web.client.TestVolume |
| | hadoop.ozone.om.TestContainerReportWithKeys |
| | hadoop.ozone.om.TestOzoneManager |
| | hadoop.ozone.om.TestOmBlockVersioning |
| | hadoop.ozone.client.rpc.TestOzoneRpcClientWithRatis |
| | hadoop.ozone.web.TestOzoneWebAccess |
| | hadoop.hdds.scm.container.TestContainerStateManagerIntegration |
| | hadoop.ozone.container.common.transport.server.ratis.TestCSMMetrics |
| | hadoop.ozone.container.common.TestBlockDeletingService |
| | hadoop.ozone.om.TestOMRatisSnapshots |
| | hadoop.ozone.web.client.TestOzoneClient |
| | hadoop.ozone.TestOzoneConfigurationFields |
| | hadoop.ozone.om.TestOzoneManagerHA |
| | hadoop.ozone.container.ozoneimpl.TestSecureOzoneContainer |
| | hadoop.ozone.om.TestMultipleContainerReadWrite |
| | hadoop.ozone.om.TestOzoneManagerConfiguration |
| | hadoop.ozone.web.TestOzoneVolumes |
| | hadoop.ozone.client.rpc.TestContainerStateMachine |
| | hadoop.hdds.scm.safemode.TestSCMSafeModeWithPipelineRules |
| | hadoop.ozone.ozShell.TestS3Shell |
| | hadoop.ozone.container.TestContainerReplication |
| | hadoop.ozone.om.TestOzoneManagerRestInterface |
| | hadoop.ozone.om.TestKeyManagerImpl |
| |
hadoop.ozone.container.common.statemachine.commandhandler.TestBlockDeletion |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1469/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1469 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle xml cc |
| uname | Linux fe85e27bb358 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | HDDS-1564 / 326b5ac |
| Default Java | 1.8.0_222 |
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1469/1/artifact/out/diff-checkstyle-hadoop-hdds.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1469/1/artifact/out/diff-javadoc-javadoc-hadoop-hdds.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1469/1/artifact/out/new-findbugs-hadoop-hdds.html
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1469/1/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1469/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1469/1/testReport/ |
| Max. process+thread count | 4989 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-hdds/container-service
hadoop-hdds/server-scm hadoop-ozone/integration-test U: . |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1469/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 314635)
Time Spent: 20m (was: 10m)
> Async RATIS pipeline creation and destroy through heartbeat commands
> --------------------------------------------------------------------
>
> Key: HDDS-2034
> URL: https://issues.apache.org/jira/browse/HDDS-2034
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Sammi Chen
> Assignee: Sammi Chen
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Currently, pipeline creation and destroy are synchronous operations. SCM
> directly connect to each datanode of the pipeline through gRPC channel to
> create the pipeline to destroy the pipeline.
> This task is to remove the gRPC channel, send pipeline creation and destroy
> action through heartbeat command to each datanode.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
