[
https://issues.apache.org/jira/browse/HDDS-2148?focusedWorklogId=314669&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-314669
]
ASF GitHub Bot logged work on HDDS-2148:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Sep/19 21:25
Start Date: 18/Sep/19 21:25
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1471: HDDS-2148.
Remove redundant code in CreateBucketHandler.java
URL: https://github.com/apache/hadoop/pull/1471#issuecomment-532873227
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 45 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| -1 | mvninstall | 32 | hadoop-ozone in trunk failed. |
| -1 | compile | 23 | hadoop-ozone in trunk failed. |
| +1 | checkstyle | 60 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 795 | branch has no errors when building and testing
our client artifacts. |
| -1 | javadoc | 49 | hadoop-ozone in trunk failed. |
| 0 | spotbugs | 159 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| -1 | findbugs | 27 | hadoop-ozone in trunk failed. |
| -0 | patch | 192 | Used diff version of patch file. Binary files and
potentially other changes not applied. Please rebase and squash commits if
necessary. |
||| _ Patch Compile Tests _ |
| -1 | mvninstall | 33 | hadoop-ozone in the patch failed. |
| -1 | compile | 25 | hadoop-ozone in the patch failed. |
| -1 | javac | 25 | hadoop-ozone in the patch failed. |
| +1 | checkstyle | 58 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 658 | patch has no errors when building and testing
our client artifacts. |
| -1 | javadoc | 47 | hadoop-ozone in the patch failed. |
| -1 | findbugs | 26 | hadoop-ozone in the patch failed. |
||| _ Other Tests _ |
| +1 | unit | 239 | hadoop-hdds in the patch passed. |
| -1 | unit | 29 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 32 | The patch does not generate ASF License warnings. |
| | | 3080 | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1471/1/artifact/out/Dockerfile
|
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux aa255146be8b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / f16eb09 |
| Default Java | 1.8.0_222 |
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1471/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1471/1/artifact/out/branch-compile-hadoop-ozone.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1471/1/artifact/out/branch-javadoc-hadoop-ozone.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1471/1/artifact/out/branch-findbugs-hadoop-ozone.txt
|
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1471/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1471/1/artifact/out/patch-compile-hadoop-ozone.txt
|
| javac |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1471/1/artifact/out/patch-compile-hadoop-ozone.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1471/1/artifact/out/patch-javadoc-hadoop-ozone.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1471/1/artifact/out/patch-findbugs-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1471/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1471/1/testReport/ |
| Max. process+thread count | 482 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/ozone-manager U: hadoop-ozone/ozone-manager |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1471/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 314669)
Time Spent: 50m (was: 40m)
> Remove redundant code in CreateBucketHandler.java
> -------------------------------------------------
>
> Key: HDDS-2148
> URL: https://issues.apache.org/jira/browse/HDDS-2148
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone CLI
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> {code:java}
> if (isVerbose()) {
> System.out.printf("Volume Name : %s%n", volumeName);
> System.out.printf("Bucket Name : %s%n", bucketName);
> if (bekName != null) {
> bb.setBucketEncryptionKey(bekName);
> System.out.printf("Bucket Encryption enabled with Key Name: %s%n",
> bekName);
> }
> }
> {code}
> This jira aims to remove the redundant line
> {{bb.setBucketEncryptionKey(bekName);}} as the same operation is performed in
> the preceding code block. This code block is to print additional details if
> verbose option was specified.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
