[
https://issues.apache.org/jira/browse/HDDS-2157?focusedWorklogId=315880&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-315880
]
ASF GitHub Bot logged work on HDDS-2157:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Sep/19 18:52
Start Date: 20/Sep/19 18:52
Worklog Time Spent: 10m
Work Description: adoroszlai commented on pull request #1485: HDDS-2157.
checkstyle: print filenames relative to project root
URL: https://github.com/apache/hadoop/pull/1485
## What changes were proposed in this pull request?
Remove project root from filenames. Also, make script slightly more
readable by breaking long sed command.
https://issues.apache.org/jira/browse/HDDS-2157
## How was this patch tested?
Introduced some checkstyle errors, then ran check:
```bash
$ git revert --no-commit 126ef77a810
$ hadoop-ozone/dev-support/checks/checkstyle.sh
...
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/db/cache/TableCache.java
88: Line is longer than 80 characters (found 91).
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/RocksDBStoreIterator.java
29: Line is longer than 80 characters (found 90).
46: Line is longer than 80 characters (found 105).
hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/utils/LevelDBStoreIterator.java
28: Line is longer than 80 characters (found 90).
hadoop-hdds/common/src/test/java/org/apache/hadoop/hdds/utils/TestMetadataStore.java
124: Line is longer than 80 characters (found 87).
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/transport/server/ratis/ContainerStateMachine.java
451: '}' at column 11 should be alone on a line.
hadoop-hdds/client/src/main/java/org/apache/hadoop/hdds/scm/client/HddsClientUtils.java
136: Line is longer than 80 characters (found 89).
144: Line is longer than 80 characters (found 81).
154: Line is longer than 80 characters (found 99).
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 315880)
Remaining Estimate: 0h
Time Spent: 10m
> checkstyle: print filenames relative to project root
> ----------------------------------------------------
>
> Key: HDDS-2157
> URL: https://issues.apache.org/jira/browse/HDDS-2157
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Components: build
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently {{checkstyle.sh}} prints files with violations using full path, eg:
> {noformat:title=https://github.com/elek/ozone-ci/blob/master/trunk/trunk-nightly-20190920-4x9x8/checkstyle/summary.txt}
> ...
> /workdir/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmMultipartUploadList.java
> 23: Unused import - org.apache.hadoop.hdds.client.ReplicationType.
> 24: Unused import -
> org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationFactor.
> /workdir/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmMultipartUploadListParts.java
> 23: Unused import -
> org.apache.hadoop.hdds.protocol.proto.HddsProtos.ReplicationType.
> /workdir/hadoop-ozone/common/src/main/java/org/apache/hadoop/ozone/om/helpers/OmMultipartKeyInfo.java
> 19: Unused import - org.apache.hadoop.hdds.client.ReplicationFactor.
> 20: Unused import - org.apache.hadoop.hdds.client.ReplicationType.
> 26: Unused import - java.time.Instant.
> ...
> {noformat}
> {{/workdir}} is specific to the CI environment. Similarly, local checkout
> directory is specific to each developer.
> Printing only path relative to project root ({{/workdir}} here) would make
> handling these paths easier (eg. reporting errors in JIRA or opening files
> locally for editing).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
