[
https://issues.apache.org/jira/browse/HDDS-2161?focusedWorklogId=316052&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316052
]
ASF GitHub Bot logged work on HDDS-2161:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Sep/19 04:34
Start Date: 21/Sep/19 04:34
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1491: HDDS-2161.
Create RepeatedKeyInfo structure to be saved in deletedTable
URL: https://github.com/apache/hadoop/pull/1491#issuecomment-533766852
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 42 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 1 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 3 new or modified test
files. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 15 | Maven dependency ordering for branch |
| -1 | mvninstall | 30 | hadoop-ozone in trunk failed. |
| -1 | compile | 22 | hadoop-ozone in trunk failed. |
| +1 | checkstyle | 52 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| -1 | shadedclient | 102 | branch has errors when building and testing our
client artifacts. |
| -1 | javadoc | 44 | hadoop-ozone in trunk failed. |
| 0 | spotbugs | 183 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| -1 | findbugs | 25 | hadoop-ozone in trunk failed. |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 15 | Maven dependency ordering for patch |
| -1 | mvninstall | 30 | hadoop-ozone in the patch failed. |
| -1 | compile | 24 | hadoop-ozone in the patch failed. |
| -1 | cc | 24 | hadoop-ozone in the patch failed. |
| -1 | javac | 24 | hadoop-ozone in the patch failed. |
| +1 | checkstyle | 51 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| -1 | shadedclient | 30 | patch has errors when building and testing our
client artifacts. |
| -1 | javadoc | 46 | hadoop-ozone in the patch failed. |
| -1 | findbugs | 22 | hadoop-ozone in the patch failed. |
||| _ Other Tests _ |
| -1 | unit | 243 | hadoop-hdds in the patch failed. |
| -1 | unit | 24 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 27 | The patch does not generate ASF License warnings. |
| | | 1732 | |
| Reason | Tests |
|-------:|:------|
| Failed junit tests | hadoop.hdds.scm.block.TestBlockManager |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1491 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle cc |
| uname | Linux aeefee5b3fd6 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6
11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / d7d6ec8 |
| Default Java | 1.8.0_222 |
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/artifact/out/branch-compile-hadoop-ozone.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/artifact/out/branch-javadoc-hadoop-ozone.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/artifact/out/branch-findbugs-hadoop-ozone.txt
|
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/artifact/out/patch-compile-hadoop-ozone.txt
|
| cc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/artifact/out/patch-compile-hadoop-ozone.txt
|
| javac |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/artifact/out/patch-compile-hadoop-ozone.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/artifact/out/patch-javadoc-hadoop-ozone.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/artifact/out/patch-findbugs-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/testReport/ |
| Max. process+thread count | 506 (vs. ulimit of 5500) |
| modules | C: hadoop-ozone/common hadoop-ozone/ozone-manager U:
hadoop-ozone |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1491/1/console |
| versions | git=2.7.4 maven=3.3.9 findbugs=3.1.0-RC1 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 316052)
Time Spent: 1h 50m (was: 1h 40m)
> Create RepeatedKeyInfo structure to be saved in deletedTable
> ------------------------------------------------------------
>
> Key: HDDS-2161
> URL: https://issues.apache.org/jira/browse/HDDS-2161
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Dinesh Chitlangia
> Assignee: Dinesh Chitlangia
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
> Currently, OM Metadata deletedTable stores <Key Name, OMKeyInfo>
> When a user deletes a Key, <key name, omKeyInfo> is moved to deletedTable.
> If a user creates and deletes key with exact same name in quick succession
> repeatedly, then old <key name, omKeyInfo> can get overwritten and we may be
> left with dangling blocks.
> To address this, currently we append delete timestamp to keyname and preserve
> the multiple delete attempts for same key name.
> However, for GDPR compliance we need a way to check if a key is deleted from
> deletedTable and thus given the above explanation, we may not get accurate
> information and it must also confuse the users.
>
> This Jira aims to:
> # Create new structure RepeatedKeyInfo which allows us to group multiple
> KeyInfo which can be saved to deletedTable corresponding to a keyname as
> <KeyName, RepeatedKeyInfo>
> # Due to this, before we move a key to deletedTable, we need to check if key
> with same name exists. If yes, then fetch the existing instance and add the
> latest key to the list, store it back to deletedTable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]