[
https://issues.apache.org/jira/browse/HDDS-1738?focusedWorklogId=316397&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-316397
]
ASF GitHub Bot logged work on HDDS-1738:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/19 04:47
Start Date: 23/Sep/19 04:47
Worklog Time Spent: 10m
Work Description: cxorm commented on pull request #1499: HDDS-1738. Add
nullable annotation for OMResponse classes.
URL: https://github.com/apache/hadoop/pull/1499
Modify classes under
hadoop/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/response/
## NOTICE
Please create an issue in ASF JIRA before opening a pull request,
and you need to set the title of the pull request which starts with
the corresponding JIRA issue number. (e.g. HADOOP-XXXXX. Fix a typo in YYY.)
For more details, please see
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 316397)
Remaining Estimate: 0h
Time Spent: 10m
> Add nullable annotation for OMResponse classes
> ----------------------------------------------
>
> Key: HDDS-1738
> URL: https://issues.apache.org/jira/browse/HDDS-1738
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: YiSheng Lien
> Priority: Major
> Labels: newbie, pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is to address [~arp] comment.
> A future improvement unrelated to your patch - replace null with Optional. Or
> at least add [@nullable|https://github.com/nullable] annotation on the
> parameter.
> Add @nullable for all OMResponse fields, where fields can be null.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
