[
https://issues.apache.org/jira/browse/HDDS-2171?focusedWorklogId=317732&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-317732
]
ASF GitHub Bot logged work on HDDS-2171:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Sep/19 18:06
Start Date: 24/Sep/19 18:06
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on pull request #1515:
HDDS-2171. Dangling links in test report due to incompatible realpath
URL: https://github.com/apache/hadoop/pull/1515#discussion_r327758756
##########
File path: hadoop-ozone/dev-support/checks/_mvn_unit_report.sh
##########
@@ -16,6 +16,15 @@
REPORT_DIR=${REPORT_DIR:-$PWD}
+_realpath() {
+ if realpath "$@" > /dev/null; then
+ realpath "$@"
+ else
+ local relative_to=$(realpath "${1/--relative-to=/}")
Review comment:
shellcheck:11: warning: Declare and assign separately to avoid masking
return values. [SC2155]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 317732)
Time Spent: 0.5h (was: 20m)
> Dangling links in test report due to incompatible realpath
> ----------------------------------------------------------
>
> Key: HDDS-2171
> URL: https://issues.apache.org/jira/browse/HDDS-2171
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: build
> Reporter: Doroszlai, Attila
> Assignee: Doroszlai, Attila
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Test summaries point to wrong locations, eg.:
> {code:title=https://raw.githubusercontent.com/elek/ozone-ci/master/trunk/trunk-nightly-20190924-mj2km/integration/summary.md}
> *
> [org.apache.hadoop.ozone.scm.node.TestQueryNode](/tmp/log/trunk/trunk-nightly-20190924-mj2km/integration/workdir/hadoop-ozone/integration-test/org.apache.hadoop.ozone.scm.node.TestQueryNode.txt)
>
> ([output](/tmp/log/trunk/trunk-nightly-20190924-mj2km/integration/workdir/hadoop-ozone/integration-test/org.apache.hadoop.ozone.scm.node.TestQueryNode-output.txt/))
> {code}
> shouldn't include {{/workdir}}, nor {{/tmp/log/}}.
> The root cause is that Busybox {{realpath}} does not accept options, rather
> returns absolute path:
> {code:title=elek/ozone-build:20190825-1}
> $ cd /etc
> $ realpath --relative-to=$(pwd) motd
> realpath: --relative-to=/etc: No such file or directory
> /etc/motd
> {code}
> It worked previously because the docker image
> [was|https://github.com/elek/argo-ozone/commit/bad4b6747fa06c227dfcbff1f098f8d9c8179b79]
> based on a more complete Linux.
> {code:title=elek/ozone-build:test}
> $ cd /etc
> $ realpath --relative-to=$(pwd) motd
> motd
> {code}
> CC [~elek]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
