[ https://issues.apache.org/jira/browse/HDDS-1868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16937742#comment-16937742 ]
Lokesh Jain commented on HDDS-1868: ----------------------------------- [~swagle] Thanks for updating the patch! The changes look good to me. Please find my comments below. # Pipeline#setLeaderId - It can be made package private. We can document that the pipeline object is immutable but we can allow classes in pipeline package to set the leaderId. # Pipeline#getFromProtobuf - We need a null check for leaderId. # XceiverServerRatis - We need to update the leaderId when StateMachine#notifyLeader is called. Also we should triggerHeartbeat once a leader change occurs. # PipelineReportHandler - We cant map a datanode to a leaderId due to multi-raft. Can we keep it simple so that we call pipeline.reportDatanode(dn) once a pipeline report with leaderId set is received? Also we can update the leaderId in the pipeline every time a pipelineReport reports a change in leaderID. > Ozone pipelines should be marked as ready only after the leader election is > complete > ------------------------------------------------------------------------------------ > > Key: HDDS-1868 > URL: https://issues.apache.org/jira/browse/HDDS-1868 > Project: Hadoop Distributed Data Store > Issue Type: Bug > Components: Ozone Datanode, SCM > Affects Versions: 0.4.0 > Reporter: Mukul Kumar Singh > Assignee: Siddharth Wagle > Priority: Major > Fix For: 0.5.0 > > Attachments: HDDS-1868.01.patch, HDDS-1868.02.patch, > HDDS-1868.03.patch, HDDS-1868.04.patch > > > Ozone pipeline on restart start in allocated state, they are moved into open > state after all the pipeline have reported to it. However this potentially > can lead into an issue where the pipeline is still not ready to accept any > incoming IO operations. > The pipelines should be marked as ready only after the leader election is > complete and leader is ready to accept incoming IO. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org