[
https://issues.apache.org/jira/browse/HDDS-2180?focusedWorklogId=318623&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-318623
]
ASF GitHub Bot logged work on HDDS-2180:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Sep/19 22:09
Start Date: 25/Sep/19 22:09
Worklog Time Spent: 10m
Work Description: xiaoyuyao commented on pull request #1526: HDDS-2180.
Add Object ID and update ID on VolumeList Object.
URL: https://github.com/apache/hadoop/pull/1526#discussion_r328361911
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/request/volume/OMVolumeRequest.java
##########
@@ -95,13 +100,18 @@ protected VolumeList addVolumeToOwnerList(VolumeList
volumeList,
}
List<String> prevVolList = new ArrayList<>();
+ long objectID = 100;
if (volumeList != null) {
prevVolList.addAll(volumeList.getVolumeNamesList());
+ objectID = volumeList.getObjectID();
Review comment:
Here we always use the objectID of the new volumeList to replace the
existing one on line 113, is this expected?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 318623)
Time Spent: 0.5h (was: 20m)
> Add Object ID and update ID on VolumeList Object
> ------------------------------------------------
>
> Key: HDDS-2180
> URL: https://issues.apache.org/jira/browse/HDDS-2180
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Anu Engineer
> Assignee: Anu Engineer
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> This JIRA proposes to add Object ID and Update IDs to the Volume List Object.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
