[
https://issues.apache.org/jira/browse/HDDS-2162?focusedWorklogId=319325&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319325
]
ASF GitHub Bot logged work on HDDS-2162:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Sep/19 02:57
Start Date: 27/Sep/19 02:57
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1511:
HDDS-2162. Make Kerberos related configuration support HA style config.
URL: https://github.com/apache/hadoop/pull/1511#discussion_r328897127
##########
File path:
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/om/TestOzoneManagerConfiguration.java
##########
@@ -119,10 +119,13 @@ public void testDefaultPortIfNotSpecified() throws
Exception {
String omNode1Id = "omNode1";
String omNode2Id = "omNode2";
String omNodesKeyValue = omNode1Id + "," + omNode2Id;
- conf.set(OMConfigKeys.OZONE_OM_NODES_KEY, omNodesKeyValue);
+ String serviceID = "service1";
+ conf.set(OMConfigKeys.OZONE_OM_SERVICE_IDS_KEY, serviceID);
+ conf.set(OMConfigKeys.OZONE_OM_NODES_KEY + "." + serviceID,
+ omNodesKeyValue);
- String omNode1RpcAddrKey = getOMAddrKeyWithSuffix(null, omNode1Id);
- String omNode2RpcAddrKey = getOMAddrKeyWithSuffix(null, omNode2Id);
+ String omNode1RpcAddrKey = getOMAddrKeyWithSuffix(serviceID, omNode1Id);
+ String omNode2RpcAddrKey = getOMAddrKeyWithSuffix(serviceID, omNode2Id);
Review comment:
Discussed offline, from my understanding this is being done as to share
config across all OM's. And this PR is not changing any config loading code of
OM HA, it just added Kerberos/DB config as described in Jira description.
Anu said we don't require the current way, and we shall continue the
discussion later to see how we can do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 319325)
Time Spent: 5h 10m (was: 5h)
> Make Kerberos related configuration support HA style config
> -----------------------------------------------------------
>
> Key: HDDS-2162
> URL: https://issues.apache.org/jira/browse/HDDS-2162
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Reporter: Bharat Viswanadham
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: pull-request-available
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> To have a single configuration to use across OM cluster, few of the configs
> like
> OZONE_OM_KERBEROS_KEYTAB_FILE_KEY,
> OZONE_OM_KERBEROS_PRINCIPAL_KEY,
> OZONE_OM_HTTP_KERBEROS_KEYTAB_FILE,
> OZONE_OM_HTTP_KERBEROS_PRINCIPAL_KEY need to support configs which append
> with service id and node id.
>
> Addressed OM_DB_DIRS, OZONE_OM_ADDRESS_KEY also in this patch.
>
> This Jira is to fix the above configs.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
