[ https://issues.apache.org/jira/browse/HDDS-1146?focusedWorklogId=319782&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-319782 ]
ASF GitHub Bot logged work on HDDS-1146: ---------------------------------------- Author: ASF GitHub Bot Created on: 27/Sep/19 19:59 Start Date: 27/Sep/19 19:59 Worklog Time Spent: 10m Work Description: anuengineer commented on pull request #1541: HDDS-1146. Adding container related metrics in SCM. URL: https://github.com/apache/hadoop/pull/1541#discussion_r329229253 ########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/container/ContainerManager.java ########## @@ -179,4 +179,12 @@ ContainerInfo getMatchingContainer(long size, String owner, */ ContainerInfo getMatchingContainer(long size, String owner, Pipeline pipeline, List<ContainerID> excludedContainerIDS); + + /** + * Once after report processor handler completes, call this to notify + * container manager to increment metrics. + * @param isFullReport + * @param success + */ + void notifyContainerReportProcessing(boolean isFullReport, boolean success); Review comment: I am not sure, But I think we have a Enum that indicates if the report is full or partial. If there is already one, then we might want to use it. Otherwise, I am okay with the boolean. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 319782) Time Spent: 20m (was: 10m) > Adding container related metrics in SCM > --------------------------------------- > > Key: HDDS-1146 > URL: https://issues.apache.org/jira/browse/HDDS-1146 > Project: Hadoop Distributed Data Store > Issue Type: Improvement > Components: SCM > Reporter: Nanda kumar > Assignee: Supratim Deka > Priority: Major > Labels: pull-request-available > Attachments: HDDS-1146.000.patch, HDDS-1146.001.patch, > HDDS-1146.002.patch > > Time Spent: 20m > Remaining Estimate: 0h > > This jira aims to add more container related metrics to SCM. > Following metrics will be added as part of this jira: > * Number of containers > * Number of open containers > * Number of closed containers > * Number of quasi closed containers > * Number of closing containers > Above are already handled in HDDS-918. > * Number of successful create container calls > * Number of failed create container calls > * Number of successful delete container calls > * Number of failed delete container calls > Handled in HDDS-2193. > * Number of successful container report processing > * Number of failed container report processing > * Number of successful incremental container report processing > * Number of failed incremental container report processing > These will be handled in this jira. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org