[ https://issues.apache.org/jira/browse/HDDS-2034?focusedWorklogId=320350&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320350 ]
ASF GitHub Bot logged work on HDDS-2034: ---------------------------------------- Author: ASF GitHub Bot Created on: 30/Sep/19 05:36 Start Date: 30/Sep/19 05:36 Worklog Time Spent: 10m Work Description: lokeshj1703 commented on pull request #1469: HDDS-2034. Async RATIS pipeline creation and destroy through heartbea… URL: https://github.com/apache/hadoop/pull/1469#discussion_r329413810 ########## File path: hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/block/BlockManagerImpl.java ########## @@ -188,6 +208,15 @@ public AllocatedBlock allocateBlock(final long size, ReplicationType type, // TODO: #CLUTIL Remove creation logic when all replication types and // factors are handled by pipeline creator pipeline = pipelineManager.createPipeline(type, factor); + // wait until pipeline is ready + long current = System.currentTimeMillis(); + while (!pipeline.isOpen() && System.currentTimeMillis() < + (current + pipelineCreateWaitTimeout)) { + try { + Thread.sleep(1000); + } catch (InterruptedException e) { + } + } Review comment: > Maybe the best way is not create pipeline in such case if we can make sure there are enough pipelines to use after exited safe mode. @ChenSammi I agree. If we can remove the pipeline creation in block allocation it would be great. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 320350) Time Spent: 10h (was: 9h 50m) > Async RATIS pipeline creation and destroy through heartbeat commands > -------------------------------------------------------------------- > > Key: HDDS-2034 > URL: https://issues.apache.org/jira/browse/HDDS-2034 > Project: Hadoop Distributed Data Store > Issue Type: Sub-task > Reporter: Sammi Chen > Assignee: Sammi Chen > Priority: Major > Labels: pull-request-available > Time Spent: 10h > Remaining Estimate: 0h > > Currently, pipeline creation and destroy are synchronous operations. SCM > directly connect to each datanode of the pipeline through gRPC channel to > create the pipeline to destroy the pipeline. > This task is to remove the gRPC channel, send pipeline creation and destroy > action through heartbeat command to each datanode. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org