[
https://issues.apache.org/jira/browse/HDFS-14775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16940674#comment-16940674
]
Xiaoqiao He edited comment on HDFS-14775 at 9/30/19 6:34 AM:
-------------------------------------------------------------
Thanks [~zhangchen] for your works. This improvement is useful for me. I prefer
[^HDFS-14775.002.patch] than the last one, I guess that you remote
AtomicReference for `longestWriteLockHeldInfo` based on only one thread could
hold WriteLock, right? maybe we could keep AtomicReference safety and it will
not take any performance overhead in my opinion. some other code style comment
but not important.
1. it should be better to follow other alignment type.
{code:java}
+ final long currentTimeMs =
+ TimeUnit.NANOSECONDS.toMillis(currentTimeStampNanos);
{code}
2. const in FSNamesystemLock#hashCode is just a little confused. is it better
with {{Objects.hashCode}}?
Ping [~xkrogen],[~linyiqun],[~elgoiri] would you help take a look?
was (Author: hexiaoqiao):
Thanks [~zhangchen] for your works. This improvement is useful for me. I prefer
[^HDFS-14775.002.patch] than the last one, I guess that you remote
AtomicReference for `longestWriteLockHeldInfo` based on only one thread could
hold WriteLock, right? maybe we could keep AtomicReference and it will not take
any performance overhead in my opinion. some other code style comment but not
important.
1. it should be better to follow other alignment type.
{code:java}
+ final long currentTimeMs =
+ TimeUnit.NANOSECONDS.toMillis(currentTimeStampNanos);
{code}
2. const in FSNamesystemLock#hashCode is just a little confused. is it better
with {{Objects.hashCode}}?
Ping [~xkrogen],[~linyiqun],[~elgoiri] would you help take a look?
> Add Timestamp for longest FSN write/read lock held log
> ------------------------------------------------------
>
> Key: HDFS-14775
> URL: https://issues.apache.org/jira/browse/HDFS-14775
> Project: Hadoop HDFS
> Issue Type: Improvement
> Reporter: Chen Zhang
> Assignee: Chen Zhang
> Priority: Major
> Attachments: HDFS-14775.001.patch, HDFS-14775.002.patch,
> HDFS-14775.003.patch
>
>
> HDFS-13946 improved the log for longest read/write lock held time, it's very
> useful improvement.
> In some condition, we need to locate the detailed call information(user, ip,
> path, etc.) for longest lock holder, but the default throttle interval(10s)
> is too long to find the corresponding audit log. I think we should add the
> timestamp for the {{longestWriteLockHeldStackTrace}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
