[
https://issues.apache.org/jira/browse/HDDS-2199?focusedWorklogId=320588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-320588
]
ASF GitHub Bot logged work on HDDS-2199:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Sep/19 15:51
Start Date: 30/Sep/19 15:51
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1551: HDDS-2199 In
SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host
URL: https://github.com/apache/hadoop/pull/1551#issuecomment-536626155
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 46 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 1 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| +1 | test4tests | 0 | The patch appears to include 3 new or modified test
files. |
||| _ trunk Compile Tests _ |
| -1 | mvninstall | 48 | hadoop-hdds in trunk failed. |
| -1 | mvninstall | 44 | hadoop-ozone in trunk failed. |
| -1 | compile | 21 | hadoop-hdds in trunk failed. |
| -1 | compile | 15 | hadoop-ozone in trunk failed. |
| +1 | checkstyle | 61 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 866 | branch has no errors when building and testing
our client artifacts. |
| -1 | javadoc | 24 | hadoop-hdds in trunk failed. |
| -1 | javadoc | 19 | hadoop-ozone in trunk failed. |
| 0 | spotbugs | 978 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| -1 | findbugs | 46 | hadoop-hdds in trunk failed. |
| -1 | findbugs | 18 | hadoop-ozone in trunk failed. |
||| _ Patch Compile Tests _ |
| -1 | mvninstall | 32 | hadoop-hdds in the patch failed. |
| -1 | mvninstall | 38 | hadoop-ozone in the patch failed. |
| -1 | compile | 24 | hadoop-hdds in the patch failed. |
| -1 | compile | 17 | hadoop-ozone in the patch failed. |
| -1 | javac | 24 | hadoop-hdds in the patch failed. |
| -1 | javac | 17 | hadoop-ozone in the patch failed. |
| -0 | checkstyle | 30 | hadoop-hdds: The patch generated 1 new + 0
unchanged - 0 fixed = 1 total (was 0) |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 713 | patch has no errors when building and testing
our client artifacts. |
| -1 | javadoc | 21 | hadoop-hdds in the patch failed. |
| -1 | javadoc | 21 | hadoop-ozone in the patch failed. |
| -1 | findbugs | 30 | hadoop-hdds in the patch failed. |
| -1 | findbugs | 22 | hadoop-ozone in the patch failed. |
||| _ Other Tests _ |
| -1 | unit | 25 | hadoop-hdds in the patch failed. |
| -1 | unit | 29 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 35 | The patch does not generate ASF License warnings. |
| | | 2401 | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.1 Server=19.03.1 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1551 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux e049700d492e 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22
16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 98ca07e |
| Default Java | 1.8.0_222 |
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
|
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/branch-compile-hadoop-hdds.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/branch-compile-hadoop-ozone.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/branch-javadoc-hadoop-hdds.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/branch-javadoc-hadoop-ozone.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/branch-findbugs-hadoop-hdds.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/branch-findbugs-hadoop-ozone.txt
|
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
|
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/patch-compile-hadoop-hdds.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/patch-compile-hadoop-ozone.txt
|
| javac |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/patch-compile-hadoop-hdds.txt
|
| javac |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/patch-compile-hadoop-ozone.txt
|
| checkstyle |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/diff-checkstyle-hadoop-hdds.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/patch-javadoc-hadoop-hdds.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/patch-javadoc-hadoop-ozone.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/patch-findbugs-hadoop-hdds.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/patch-findbugs-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/testReport/ |
| Max. process+thread count | 412 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/server-scm U: hadoop-hdds/server-scm |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1551/1/console |
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 320588)
Time Spent: 0.5h (was: 20m)
> In SCMNodeManager dnsToUuidMap cannot track multiple DNs on the same host
> -------------------------------------------------------------------------
>
> Key: HDDS-2199
> URL: https://issues.apache.org/jira/browse/HDDS-2199
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Affects Versions: 0.5.0
> Reporter: Stephen O'Donnell
> Assignee: Stephen O'Donnell
> Priority: Major
> Labels: pull-request-available
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Often in test clusters and tests, we start multiple datanodes on the same
> host.
> In SCMNodeManager.register() there is a map of hostname -> datanode UUID
> called dnsToUuidMap.
> If several DNs register from the same host, the entry in the map will be
> overwritten and the last DN to register will 'win'.
> This means that the method getNodeByAddress() does not return the correct
> DatanodeDetails object when many hosts are registered from the same address.
> This method is only used in SCMBlockProtocolServer.sortDatanodes() to allow
> it to see if one of the nodes matches the client, but it need to be used by
> the Decommission code.
> Perhaps we could change the getNodeByAddress() method to returns a list of
> DNs? In normal production clusters, there should only be one returned, but in
> test clusters, there may be many. Any code looking for a specific DN entry
> would need to iterate the list and match on the port number too, as host:port
> would be the unique definition of a datanode.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
