[
https://issues.apache.org/jira/browse/HDDS-2073?focusedWorklogId=321428&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321428
]
ASF GitHub Bot logged work on HDDS-2073:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Oct/19 18:26
Start Date: 01/Oct/19 18:26
Worklog Time Spent: 10m
Work Description: arp7 commented on pull request #1521: HDDS-2073. Make
SCMSecurityProtocol message based
URL: https://github.com/apache/hadoop/pull/1521#discussion_r330206688
##########
File path: hadoop-hdds/common/src/main/proto/SCMSecurityProtocol.proto
##########
@@ -30,33 +30,73 @@ option java_generic_services = true;
option java_generate_equals_and_hash = true;
-package hadoop.hdds;
+package hadoop.hdds.security;
import "hdds.proto";
+
+message SCMSecurityRequest {
Review comment:
A short comment here would be helpful for maintainers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 321428)
Time Spent: 1h (was: 50m)
> Make SCMSecurityProtocol message based
> --------------------------------------
>
> Key: HDDS-2073
> URL: https://issues.apache.org/jira/browse/HDDS-2073
> Project: Hadoop Distributed Data Store
> Issue Type: Sub-task
> Components: SCM
> Reporter: Marton Elek
> Assignee: Marton Elek
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> We started to use a generic pattern where we have only one method in the grpc
> service and the main message contains all the required common information
> (eg. tracing).
> SCMSecurityProtocol.proto is not yet migrated to this approach. To make our
> generic debug tool more powerful and unify our protocols I suggest to
> transform this protocol as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
