[
https://issues.apache.org/jira/browse/HDDS-2158?focusedWorklogId=321599&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-321599
]
ASF GitHub Bot logged work on HDDS-2158:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Oct/19 22:27
Start Date: 01/Oct/19 22:27
Worklog Time Spent: 10m
Work Description: hanishakoneru commented on pull request #1486:
HDDS-2158. Fixing Json Injection Issue in JsonUtils.
URL: https://github.com/apache/hadoop/pull/1486#discussion_r330304233
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/web/ozShell/bucket/RemoveAclBucketHandler.java
##########
@@ -92,8 +92,9 @@ public Void call() throws Exception {
boolean result = client.getObjectStore().removeAcl(obj,
OzoneAcl.parseAcl(acl));
- System.out.printf("%s%n", JsonUtils.toJsonStringWithDefaultPrettyPrinter(
- JsonUtils.toJsonString("Acl removed successfully: " + result)));
+ System.out.printf("%s%n", result ? "ACL removed successfully" :
+ "ACL not removed");
Review comment:
I reverted to previous print messages (fixing add/set/remove part only).
But I think that statement also does not convey the message properly. If we
are trying to add an already existing ACL, shouldn't we return true? And same
for remove also.
We can open a new Jira to work on that if you agree.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 321599)
Time Spent: 3h (was: 2h 50m)
> Fix Json Injection in JsonUtils
> -------------------------------
>
> Key: HDDS-2158
> URL: https://issues.apache.org/jira/browse/HDDS-2158
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Hanisha Koneru
> Assignee: Hanisha Koneru
> Priority: Major
> Labels: pull-request-available
> Time Spent: 3h
> Remaining Estimate: 0h
>
> JsonUtils#toJsonStringWithDefaultPrettyPrinter() does not validate the Json
> String before serializing it which could result in Json Injection.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
