[ 
https://issues.apache.org/jira/browse/HDFS-14881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16942478#comment-16942478
 ] 

Renukaprasad C commented on HDFS-14881:
---------------------------------------

Thank you [~ayushtkn],

Indentation changes done as part of Checkstyle issue in the modified line. My 
code changes done only for displaying the CORRECT help message. Though 
Checkstyle issue exists in base, it got identified as line modified (on 
differencial code). Either i can fix the issue on the line which i have 
modified or fix on whole section of the statement split into muliple line. 

Fixing the issue on single line - code looks ugly as single statement has 
different indentation (couple of fixes done in the same bunch of code in the 
past).

Fixing the issue on entire section - corrects the indentation issue but extra 
changes involved.

Test changes not required for this issue, I will remove the test changes as 
part of this issue.

Please review & share your input, I will update the patch accordingly.

 

> Safemode 'forceExit' option, doesn’t shown in help message
> ----------------------------------------------------------
>
>                 Key: HDFS-14881
>                 URL: https://issues.apache.org/jira/browse/HDFS-14881
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Renukaprasad C
>            Assignee: Renukaprasad C
>            Priority: Major
>         Attachments: HDFS-14881.001.patch, HDFS-14881.002.patch
>
>
> Safemode option 'forceExit' doesn’t shown in help message.
> bin # ./hdfs dfsadmin
> Usage: hdfs dfsadmin
> Note: Administrative commands can only be run as the HDFS superuser.
>         [-report [-live] [-dead] [-decommissioning] [-enteringmaintenance] 
> [-inmaintenance]]
>         [-safemode <enter | leave | get | wait>]
> 'forceExit' option become hidden option, end user will not aware of such 
> option from command help.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to