[
https://issues.apache.org/jira/browse/HDDS-2254?focusedWorklogId=323949&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-323949
]
ASF GitHub Bot logged work on HDDS-2254:
----------------------------------------
Author: ASF GitHub Bot
Created on: 05/Oct/19 15:56
Start Date: 05/Oct/19 15:56
Worklog Time Spent: 10m
Work Description: avijayanhwx commented on pull request #1604: HDDS-2254
: Fix flaky unit test TestContainerStateMachine#testRatisSnapshotRetention
URL: https://github.com/apache/hadoop/pull/1604
What changes were proposed in this pull request?
On locally trying out repeated runs of the unit test, the unit test failed
intermittently while asserting "Null" value for CSM snapshot. This assertion is
not valid when the other unit test in the class executes before and creates
keys in the cluster/container. Removed the null check since it does not test
the core functionality of snapshot retention.
https://issues.apache.org/jira/browse/HDDS-2254
How was this patch tested?
Ran the unit tests a few hundred times in IDE in different order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 323949)
Remaining Estimate: 0h
Time Spent: 10m
> Fix flaky unit testTestContainerStateMachine#testRatisSnapshotRetention
> -----------------------------------------------------------------------
>
> Key: HDDS-2254
> URL: https://issues.apache.org/jira/browse/HDDS-2254
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: test
> Affects Versions: 0.5.0
> Reporter: Siddharth Wagle
> Assignee: Aravindan Vijayan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Test always fails with assertion error:
> {code}
> java.lang.AssertionError
> at org.junit.Assert.fail(Assert.java:86)
> at org.junit.Assert.assertTrue(Assert.java:41)
> at org.junit.Assert.assertTrue(Assert.java:52)
> at
> org.apache.hadoop.ozone.client.rpc.TestContainerStateMachine.testRatisSnapshotRetention(TestContainerStateMachine.java:188)
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
