[
https://issues.apache.org/jira/browse/HDDS-2233?focusedWorklogId=324136&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-324136
]
ASF GitHub Bot logged work on HDDS-2233:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Oct/19 03:46
Start Date: 07/Oct/19 03:46
Worklog Time Spent: 10m
Work Description: bshashikant commented on issue #1596: HDDS-2233 -
Remove ByteStringHelper and refactor the code to the place where it used
URL: https://github.com/apache/hadoop/pull/1596#issuecomment-538829264
Thanks @fapifta for working on this. In addition to Mukul's comments, I feel
ByteBuffer to byteString conversion should be a general utility function and
should not take configuration object as dependency to determine safe or unsafe
copy. Let's pass the boolean flag instead as it would be more friendly to use
where ever needed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 324136)
Time Spent: 1h 20m (was: 1h 10m)
> Remove ByteStringHelper and refactor the code to the place where it used
> ------------------------------------------------------------------------
>
> Key: HDDS-2233
> URL: https://issues.apache.org/jira/browse/HDDS-2233
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Reporter: Istvan Fajth
> Priority: Critical
> Labels: pull-request-available
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> See HDDS-2203 where there is a race condition reported by me.
> Later in the discussion we agreed that it is better to refactor the code and
> remove the class completely for now, and that would also resolve the race
> condition.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org
