[
https://issues.apache.org/jira/browse/HDDS-2271?focusedWorklogId=325611&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-325611
]
ASF GitHub Bot logged work on HDDS-2271:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/19 09:54
Start Date: 09/Oct/19 09:54
Worklog Time Spent: 10m
Work Description: hadoop-yetus commented on issue #1625: HDDS-2271. Avoid
buffer copying in KeyValueHandler.
URL: https://github.com/apache/hadoop/pull/1625#issuecomment-539929052
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|:----:|----------:|--------:|:--------|
| 0 | reexec | 38 | Docker mode activated. |
||| _ Prechecks _ |
| +1 | dupname | 0 | No case conflicting files found. |
| +1 | @author | 0 | The patch does not contain any @author tags. |
| -1 | test4tests | 0 | The patch doesn't appear to include any new or
modified tests. Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch. |
||| _ trunk Compile Tests _ |
| 0 | mvndep | 30 | Maven dependency ordering for branch |
| -1 | mvninstall | 36 | hadoop-hdds in trunk failed. |
| -1 | mvninstall | 43 | hadoop-ozone in trunk failed. |
| -1 | compile | 24 | hadoop-hdds in trunk failed. |
| -1 | compile | 15 | hadoop-ozone in trunk failed. |
| +1 | checkstyle | 63 | trunk passed |
| +1 | mvnsite | 0 | trunk passed |
| +1 | shadedclient | 1100 | branch has no errors when building and testing
our client artifacts. |
| -1 | javadoc | 21 | hadoop-hdds in trunk failed. |
| -1 | javadoc | 18 | hadoop-ozone in trunk failed. |
| 0 | spotbugs | 1207 | Used deprecated FindBugs config; considering
switching to SpotBugs. |
| -1 | findbugs | 42 | hadoop-hdds in trunk failed. |
| -1 | findbugs | 21 | hadoop-ozone in trunk failed. |
||| _ Patch Compile Tests _ |
| 0 | mvndep | 21 | Maven dependency ordering for patch |
| -1 | mvninstall | 41 | hadoop-hdds in the patch failed. |
| -1 | mvninstall | 38 | hadoop-ozone in the patch failed. |
| -1 | compile | 27 | hadoop-hdds in the patch failed. |
| -1 | compile | 19 | hadoop-ozone in the patch failed. |
| -1 | javac | 27 | hadoop-hdds in the patch failed. |
| -1 | javac | 19 | hadoop-ozone in the patch failed. |
| +1 | checkstyle | 60 | the patch passed |
| +1 | mvnsite | 0 | the patch passed |
| +1 | whitespace | 0 | The patch has no whitespace issues. |
| +1 | shadedclient | 906 | patch has no errors when building and testing
our client artifacts. |
| -1 | javadoc | 23 | hadoop-hdds in the patch failed. |
| -1 | javadoc | 19 | hadoop-ozone in the patch failed. |
| -1 | findbugs | 37 | hadoop-hdds in the patch failed. |
| -1 | findbugs | 22 | hadoop-ozone in the patch failed. |
||| _ Other Tests _ |
| -1 | unit | 31 | hadoop-hdds in the patch failed. |
| -1 | unit | 28 | hadoop-ozone in the patch failed. |
| +1 | asflicense | 36 | The patch does not generate ASF License warnings. |
| | | 2895 | |
| Subsystem | Report/Notes |
|----------:|:-------------|
| Docker | Client=19.03.3 Server=19.03.3 base:
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/Dockerfile
|
| GITHUB PR | https://github.com/apache/hadoop/pull/1625 |
| Optional Tests | dupname asflicense compile javac javadoc mvninstall
mvnsite unit shadedclient findbugs checkstyle |
| uname | Linux 0f04dd4fe3d0 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | personality/hadoop.sh |
| git revision | trunk / 1d27930 |
| Default Java | 1.8.0_222 |
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/branch-mvninstall-hadoop-hdds.txt
|
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/branch-mvninstall-hadoop-ozone.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/branch-compile-hadoop-hdds.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/branch-compile-hadoop-ozone.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/branch-javadoc-hadoop-hdds.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/branch-javadoc-hadoop-ozone.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/branch-findbugs-hadoop-hdds.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/branch-findbugs-hadoop-ozone.txt
|
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/patch-mvninstall-hadoop-hdds.txt
|
| mvninstall |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/patch-mvninstall-hadoop-ozone.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/patch-compile-hadoop-hdds.txt
|
| compile |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/patch-compile-hadoop-ozone.txt
|
| javac |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/patch-compile-hadoop-hdds.txt
|
| javac |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/patch-compile-hadoop-ozone.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/patch-javadoc-hadoop-hdds.txt
|
| javadoc |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/patch-javadoc-hadoop-ozone.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/patch-findbugs-hadoop-hdds.txt
|
| findbugs |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/patch-findbugs-hadoop-ozone.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/patch-unit-hadoop-hdds.txt
|
| unit |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/artifact/out/patch-unit-hadoop-ozone.txt
|
| Test Results |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/testReport/ |
| Max. process+thread count | 306 (vs. ulimit of 5500) |
| modules | C: hadoop-hdds/common hadoop-hdds/container-service U:
hadoop-hdds |
| Console output |
https://builds.apache.org/job/hadoop-multibranch/job/PR-1625/1/console |
| versions | git=2.7.4 maven=3.3.9 |
| Powered by | Apache Yetus 0.10.0 http://yetus.apache.org |
This message was automatically generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 325611)
Time Spent: 20m (was: 10m)
> Avoid buffer copying in KeyValueHandler
> ---------------------------------------
>
> Key: HDDS-2271
> URL: https://issues.apache.org/jira/browse/HDDS-2271
> Project: Hadoop Distributed Data Store
> Issue Type: Improvement
> Reporter: Tsz-wo Sze
> Assignee: Tsz-wo Sze
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> - In handleGetSmallFile, it first reads chunk data to a byte[] and the copy
> them to a ByteString.
> - In handlePutBlock/handleGetBlock, in order to get the length, it (1) builds
> a ContainerProtos.BlockData and then copies it to a byte[].
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
