[ 
https://issues.apache.org/jira/browse/HDFS-14739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947674#comment-16947674
 ] 

Jinglun commented on HDFS-14739:
--------------------------------

Hi [~elgoiri] [~ayushtkn], what do you think about TestDisableNameservices ?

When we enable default namespace and do a list on a directory which could not 
be found in mount tables, a path based on default namespace would be listed. 
But if the default namespace is disabled, the path created by default namespace 
would be excluded, and an IOException would be thrown. That's why in 
TestDisableNameservices we used try catch in testDisabling(), because the first 
line of testDisabling() was to disable the default namespace. 

I thought removing the try catch in testDisabling() might be acceptable because 
we have fixed the problem when listing a non-existed path without a default 
namespace or a mount table '/'. 

In my opinion, the main purpose of testWithoutDisabling() and testDisabling() 
was to test whether the namespace has been successfully disabled. We have a 
slow namespace ns0 and a fast namespace ns1. So we expect the renewLease() in 
testWithoutDisabling() costs a longer time than in testDisabling(). The 
listStatus() part in the test cases was not very close to the main purpose so 
changing it won't damage the 2 test cases.

> RBF: LS command for mount point shows wrong owner and permission information.
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-14739
>                 URL: https://issues.apache.org/jira/browse/HDFS-14739
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: xuzq
>            Assignee: Jinglun
>            Priority: Major
>         Attachments: HDFS-14739-trunk-001.patch, HDFS-14739-trunk-002.patch, 
> HDFS-14739-trunk-003.patch, HDFS-14739-trunk-004.patch, 
> HDFS-14739-trunk-005.patch, image-2019-08-16-17-15-50-614.png, 
> image-2019-08-16-17-16-00-863.png, image-2019-08-16-17-16-34-325.png
>
>
> ||source||target namespace||destination||owner||group||permission||
> |/mnt|ns0|/mnt|mnt|mnt_group|755|
> |/mnt/test1|ns1|/mnt/test1|mnt_test1|mnt_test1_group|755|
> |/test1|ns1|/test1|test1|test1_group|755|
> When do getListing("/mnt"), the owner of  */mnt/test1* should be *mnt_test1* 
> instead of *test1* in result.
>  
> And if the mount table as blew, we should support getListing("/mnt") instead 
> of throw IOException when dfs.federation.router.default.nameservice.enable is 
> false.
> ||source||target namespace||destination||owner||group||permission||
> |/mnt/test1|ns0|/mnt/test1|test1|test1|755|
> |/mnt/test2|ns1|/mnt/test2|test2|test2|755|
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to