[
https://issues.apache.org/jira/browse/HDDS-2181?focusedWorklogId=326006&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-326006
]
ASF GitHub Bot logged work on HDDS-2181:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Oct/19 23:38
Start Date: 09/Oct/19 23:38
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #1528:
HDDS-2181. Ozone Manager should send correct ACL type in ACL requests…
URL: https://github.com/apache/hadoop/pull/1528#discussion_r333277411
##########
File path:
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
##########
@@ -1656,8 +1657,13 @@ public boolean checkAccess(OzoneObj ozObject,
RequestContext context)
validateBucket(volume, bucket);
OmKeyInfo keyInfo = null;
try {
- OzoneFileStatus fileStatus = getFileStatus(args);
- keyInfo = fileStatus.getKeyInfo();
+ if (ozObject.getResourceType() == OPEN_KEY) {
+ keyInfo = metadataManager.getOpenKeyTable().get(objectKey);
+ } else {
+ OzoneFileStatus fileStatus = getFileStatus(args);
+ keyInfo = fileStatus.getKeyInfo();
+ }
+
Review comment:
We Should remove lines from 1675-1677 And 1680-1683. As we have handled
using openKey. So, we should throw an exception in CatchBlock
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 326006)
Time Spent: 8h 40m (was: 8.5h)
> Ozone Manager should send correct ACL type in ACL requests to Authorizer
> ------------------------------------------------------------------------
>
> Key: HDDS-2181
> URL: https://issues.apache.org/jira/browse/HDDS-2181
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Manager
> Affects Versions: 0.4.1
> Reporter: Vivek Ratnavel Subramanian
> Assignee: Vivek Ratnavel Subramanian
> Priority: Major
> Labels: pull-request-available
> Time Spent: 8h 40m
> Remaining Estimate: 0h
>
> Currently, Ozone manager sends "WRITE" as ACLType for key create, key delete
> and bucket create operation. Fix the acl type in all requests to the
> authorizer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
