[ 
https://issues.apache.org/jira/browse/HDDS-2181?focusedWorklogId=327001&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327001
 ]

ASF GitHub Bot logged work on HDDS-2181:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Oct/19 17:08
            Start Date: 11/Oct/19 17:08
    Worklog Time Spent: 10m 
      Work Description: xiaoyuyao commented on pull request #1528: HDDS-2181. 
Ozone Manager should send correct ACL type in ACL requests…
URL: https://github.com/apache/hadoop/pull/1528#discussion_r334089125
 
 

 ##########
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java
 ##########
 @@ -1654,28 +1655,28 @@ public boolean checkAccess(OzoneObj ozObject, 
RequestContext context)
     metadataManager.getLock().acquireReadLock(BUCKET_LOCK, volume, bucket);
     try {
       validateBucket(volume, bucket);
-      OmKeyInfo keyInfo = null;
-      try {
-        OzoneFileStatus fileStatus = getFileStatus(args);
-        keyInfo = fileStatus.getKeyInfo();
-        if (keyInfo == null) {
-          // the key does not exist, but it is a parent "dir" of some key
-          // let access be determined based on volume/bucket/prefix ACL
-          if (LOG.isDebugEnabled()) {
-            LOG.debug("key:{} is non-existent parent, permit access to 
user:{}",
-                keyName, context.getClientUgi());
-          }
-          return true;
-        }
-      } catch (OMException e) {
-        if (e.getResult() == FILE_NOT_FOUND) {
-          keyInfo = metadataManager.getOpenKeyTable().get(objectKey);
+      OmKeyInfo keyInfo;
+
+      if (ozObject.getResourceType() == OPEN_KEY) {
 
 Review comment:
   what's the difference between OPEN_KEY->CREATE and KEY->CREATE?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 327001)
    Time Spent: 10h 40m  (was: 10.5h)

> Ozone Manager should send correct ACL type in ACL requests to Authorizer
> ------------------------------------------------------------------------
>
>                 Key: HDDS-2181
>                 URL: https://issues.apache.org/jira/browse/HDDS-2181
>             Project: Hadoop Distributed Data Store
>          Issue Type: Bug
>          Components: Ozone Manager
>    Affects Versions: 0.4.1
>            Reporter: Vivek Ratnavel Subramanian
>            Assignee: Vivek Ratnavel Subramanian
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10h 40m
>  Remaining Estimate: 0h
>
> Currently, Ozone manager sends "WRITE" as ACLType for key create, key delete 
> and bucket create operation. Fix the acl type in all requests to the 
> authorizer.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to