[ 
https://issues.apache.org/jira/browse/HDDS-1228?focusedWorklogId=327064&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327064
 ]

ASF GitHub Bot logged work on HDDS-1228:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Oct/19 20:36
            Start Date: 11/Oct/19 20:36
    Worklog Time Spent: 10m 
      Work Description: arp7 commented on pull request #1622: HDDS-1228. Chunk 
Scanner Checkpoints
URL: https://github.com/apache/hadoop/pull/1622#discussion_r334164946
 
 

 ##########
 File path: 
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/ContainerDataScanner.java
 ##########
 @@ -95,14 +97,19 @@ public void runIteration() {
     while (!stopping && itr.hasNext()) {
       Container c = itr.next();
       if (c.shouldScanData()) {
+        ContainerData containerData = c.getContainerData();
+        long containerId = containerData.getContainerID();
         try {
+          logScanStart(containerData);
           if (!c.scanData(throttler, canceler)) {
             metrics.incNumUnHealthyContainers();
-            controller.markContainerUnhealthy(
-                c.getContainerData().getContainerID());
+            controller.markContainerUnhealthy(containerId);
 
 Review comment:
   We should also call `logScanCompleted` and `updateDataScanTimestamp` in the 
failure path.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 327064)
    Time Spent: 1h 10m  (was: 1h)

> Chunk Scanner Checkpoints
> -------------------------
>
>                 Key: HDDS-1228
>                 URL: https://issues.apache.org/jira/browse/HDDS-1228
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: Ozone Datanode
>            Reporter: Supratim Deka
>            Assignee: Attila Doroszlai
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 0.5.0
>
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> Checkpoint the progress of the chunk verification scanner.
> Save the checkpoint persistently to support scanner resume from checkpoint - 
> after a datanode restart.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to