[ 
https://issues.apache.org/jira/browse/HDDS-2206?focusedWorklogId=327082&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-327082
 ]

ASF GitHub Bot logged work on HDDS-2206:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Oct/19 21:15
            Start Date: 11/Oct/19 21:15
    Worklog Time Spent: 10m 
      Work Description: arp7 commented on pull request #1637: HDDS-2206. 
Separate handling for OMException and IOException in the Ozone Manager. 
Contributed by Supratim Deka
URL: https://github.com/apache/hadoop/pull/1637#discussion_r334176751
 
 

 ##########
 File path: 
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java
 ##########
 @@ -219,7 +244,7 @@ private OMResponse submitRequestDirectlyToOM(OMRequest 
request) {
         omClientResponse = omClientRequest.validateAndUpdateCache(
             ozoneManager, index, ozoneManagerDoubleBuffer::add);
       }
-    } catch(IOException ex) {
+    } catch(OMException ex) {
 
 Review comment:
   I think we don't need this catch block at all, as the caller will do the 
right thing via the call to `createErrorResponse`.
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 327082)
    Time Spent: 1h  (was: 50m)

> Separate handling for OMException and IOException in the Ozone Manager
> ----------------------------------------------------------------------
>
>                 Key: HDDS-2206
>                 URL: https://issues.apache.org/jira/browse/HDDS-2206
>             Project: Hadoop Distributed Data Store
>          Issue Type: Sub-task
>          Components: Ozone Manager
>            Reporter: Supratim Deka
>            Assignee: Supratim Deka
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> As part of improving error propagation from the OM for ease of 
> troubleshooting and diagnosis, the proposal is to handle IOExceptions 
> separately from the business exceptions which are thrown as OMExceptions.
> Handling for OMExceptions will not be changed in this jira.
> Handling for IOExceptions will include logging the stacktrace on the server, 
> and propagation to the client under the control of a config parameter.
> Similar handling is also proposed for SCMException.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org

Reply via email to