[ https://issues.apache.org/jira/browse/HDFS-14739?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16949923#comment-16949923 ]
Ayush Saxena commented on HDFS-14739: ------------------------------------- {quote}can we just make the whole locations part to go within the try/catch so we don't need to have a separate definition of List<RemoteLocation> locations? {quote} I think this is not addressed. IIUC this meant something like this : {code:java} private List<RemoteResult<RemoteLocation, DirectoryListing>> getListingInt( String src, byte[] startAfter, boolean needLocation) throws IOException { try { List<RemoteLocation> locations = rpcServer.getLocationsForPath(src, false, false); // Locate the dir and fetch the listing. RemoteMethod method = new RemoteMethod("getListing", new Class<?>[] { String.class, startAfter.getClass(), boolean.class }, new RemoteParam(), startAfter, needLocation); List<RemoteResult<RemoteLocation, DirectoryListing>> listings = rpcClient.invokeConcurrent(locations, method, false, -1, DirectoryListing.class); return listings; } catch (RouterResolveException e) { LOG.debug("Cannot get locations for {}, {}.", src, e.getMessage()); return new ArrayList<>(); } } {code} [~elgoiri] can you confirm once? {{TestRouterWebHDFSContractSeek}} seems unrelated, looks like broken by HADOOP-15870. I need to check, we need to track this too separately. > RBF: LS command for mount point shows wrong owner and permission information. > ----------------------------------------------------------------------------- > > Key: HDFS-14739 > URL: https://issues.apache.org/jira/browse/HDFS-14739 > Project: Hadoop HDFS > Issue Type: Bug > Reporter: xuzq > Assignee: Jinglun > Priority: Major > Attachments: HDFS-14739-trunk-001.patch, HDFS-14739-trunk-002.patch, > HDFS-14739-trunk-003.patch, HDFS-14739-trunk-004.patch, > HDFS-14739-trunk-005.patch, HDFS-14739-trunk-006.patch, > HDFS-14739-trunk-007.patch, HDFS-14739-trunk-008.patch, > HDFS-14739-trunk-009.patch, HDFS-14739-trunk-010.patch, > image-2019-08-16-17-15-50-614.png, image-2019-08-16-17-16-00-863.png, > image-2019-08-16-17-16-34-325.png > > > ||source||target namespace||destination||owner||group||permission|| > |/mnt|ns0|/mnt|mnt|mnt_group|755| > |/mnt/test1|ns1|/mnt/test1|mnt_test1|mnt_test1_group|755| > |/test1|ns1|/test1|test1|test1_group|755| > When do getListing("/mnt"), the owner of */mnt/test1* should be *mnt_test1* > instead of *test1* in result. > > And if the mount table as blew, we should support getListing("/mnt") instead > of throw IOException when dfs.federation.router.default.nameservice.enable is > false. > ||source||target namespace||destination||owner||group||permission|| > |/mnt/test1|ns0|/mnt/test1|test1|test1|755| > |/mnt/test2|ns1|/mnt/test2|test2|test2|755| > > -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: hdfs-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: hdfs-issues-h...@hadoop.apache.org