[
https://issues.apache.org/jira/browse/HDFS-14546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16952893#comment-16952893
]
Ayush Saxena commented on HDFS-14546:
-------------------------------------
Thanx [~Amithsha] for the patch. Almost looks good, couple of things :
This isn't required :
{code:java}
+* [Block Placement Policies](#Block_Placement_Policies)
+ * [Introduction](#Introduction)
+ * [Additional Types of Policies](#Policy_Types)
+ *
[BlockPlacementPolicyRackFaultTolerant](#Block_PlacementPolicy_RackFaultTolerant)
+ * [BlockPlacementPolicyWithNodeGroup](#BlockPlacementPolicy_With_NodeGroup)
+ *
[BlockPlacementPolicyWithUpgradeDomain](#BlockPlacementPolicy_With_UpgradeDomain)
{code}
Just having a single line, will automatically generate this, Like :
{code:java}
BlockPlacementPolicies
======================
<!-- MACRO{toc|fromDepth=0|toDepth=3} --> // Add this line
##Introduction
{code}
These should have ## rather than ###
{code:java}
+### BlockPlacementPolicyRackFaultTolerant
{code}
These Links should be relative paths :
{code:java}
+Detailed info about configuration
https://hadoop.apache.org/docs/current/hadoop-project-dist/hadoop-hdfs/HdfsUpgradeDomain.html
{code}
The image has too much whitespace at the bottom can you reduce it. It makes the
text go too much below.
Let me know, if you are facing any problem or need any help handling anything,
I can help.
[~elgoiri] you want to add anything?
> Document block placement policies
> ---------------------------------
>
> Key: HDFS-14546
> URL: https://issues.apache.org/jira/browse/HDFS-14546
> Project: Hadoop HDFS
> Issue Type: Bug
> Reporter: Íñigo Goiri
> Assignee: Amithsha
> Priority: Major
> Labels: documentation
> Attachments: HDFS-14546-01.patch, HDFS-14546-02.patch,
> HDFS-14546-03.patch, HDFS-14546-04.patch, HDFS-14546-05.patch,
> HDFS-14546-06.patch, HdfsDesign.patch
>
>
> Currently, all the documentation refers to the default block placement policy.
> However, over time there have been new policies:
> * BlockPlacementPolicyRackFaultTolerant (HDFS-7891)
> * BlockPlacementPolicyWithNodeGroup (HDFS-3601)
> * BlockPlacementPolicyWithUpgradeDomain (HDFS-9006)
> We should update the documentation to refer to them explaining their
> particularities and probably how to setup each one of them.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
