[
https://issues.apache.org/jira/browse/HDDS-2318?focusedWorklogId=330026&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-330026
]
ASF GitHub Bot logged work on HDDS-2318:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Oct/19 17:39
Start Date: 17/Oct/19 17:39
Worklog Time Spent: 10m
Work Description: bharatviswa504 commented on pull request #48:
HDDS-2318. Avoid proto::tostring in preconditions to save CPU cycles.
URL: https://github.com/apache/hadoop-ozone/pull/48
## What changes were proposed in this pull request?
Avoiding proto::toString in OzoneManagerServerSideTranslatorPB.java
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-2318
## How was this patch tested?
Ran TestOzoneRpcClient which executes this code path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 330026)
Remaining Estimate: 0h
Time Spent: 10m
> Avoid proto::tostring in preconditions to save CPU cycles
> ---------------------------------------------------------
>
> Key: HDDS-2318
> URL: https://issues.apache.org/jira/browse/HDDS-2318
> Project: Hadoop Distributed Data Store
> Issue Type: Bug
> Components: Ozone Manager
> Reporter: Rajesh Balamohan
> Assignee: Bharat Viswanadham
> Priority: Major
> Labels: performance, pull-request-available
> Attachments: Screenshot 2019-10-17 at 6.10.22 PM.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [https://github.com/apache/hadoop-ozone/blob/61f4aa30f502b34fd778d9b37b1168721abafb2f/hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/protocolPB/OzoneManagerProtocolServerSideTranslatorPB.java#L117]
>
> This ends up converting proto toString in precondition checks and burns CPU
> cycles. {{request.toString()}} can be added in debug log on need basis.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
